Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
includes/ExtMobileFrontend.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method domParseMobile has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function domParseMobile( OutputPage $out, $html = '' ) {
        $services = MediaWikiServices::getInstance();
        /** @var FeaturesManager $featuresManager */
        $featuresManager = $services->getService( 'MobileFrontend.FeaturesManager' );
        /** @var MobileContext $context */
Severity: Major
Found in includes/ExtMobileFrontend.php - About 2 hrs to fix

    Function domParseMobile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function domParseMobile( OutputPage $out, $html = '' ) {
        $services = MediaWikiServices::getInstance();
        /** @var FeaturesManager $featuresManager */
        $featuresManager = $services->getService( 'MobileFrontend.FeaturesManager' );
        /** @var MobileContext $context */
    Severity: Minor
    Found in includes/ExtMobileFrontend.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getUserPageContent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected static function getUserPageContent( IContextSource $output,
        User $pageUser, Title $title
    ) {
        /** @var MobileContext $context */
        $context = MediaWikiServices::getInstance()->getService( 'MobileFrontend.Context' );
    Severity: Minor
    Found in includes/ExtMobileFrontend.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status