Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
includes/MobileFrontendEditorHooks.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method isSupportedEditRequest has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static function isSupportedEditRequest( IContextSource $context ) {
        /** @var MobileContext $mobileContext */
        $mobileContext = MediaWikiServices::getInstance()->getService( 'MobileFrontend.Context' );
        if ( !$mobileContext->shouldDisplayMobileView() ) {
            return false;
Severity: Minor
Found in includes/MobileFrontendEditorHooks.php - About 1 hr to fix

    Method onCustomEditor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function onCustomEditor( $article, $user ) {
        $req = $article->getContext()->getRequest();
        $title = $article->getTitle();
        if (
            !$req->getVal( 'mfnoscript' ) &&
    Severity: Minor
    Found in includes/MobileFrontendEditorHooks.php - About 1 hr to fix

      Function isSupportedEditRequest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected static function isSupportedEditRequest( IContextSource $context ) {
        /** @var MobileContext $mobileContext */
        $mobileContext = MediaWikiServices::getInstance()->getService( 'MobileFrontend.Context' );
        if ( !$mobileContext->shouldDisplayMobileView() ) {
            return false;
      Severity: Minor
      Found in includes/MobileFrontendEditorHooks.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in includes/MobileFrontendEditorHooks.php - About 30 mins to fix

              Function onCustomEditor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function onCustomEditor( $article, $user ) {
        $req = $article->getContext()->getRequest();
        $title = $article->getTitle();
        if (
            !$req->getVal( 'mfnoscript' ) &&
              Severity: Minor
              Found in includes/MobileFrontendEditorHooks.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status