Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
includes/Transforms/MoveLeadParagraphTransform.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function moveFirstParagraphBeforeInfobox has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private function moveFirstParagraphBeforeInfobox( DOMElement $leadSection, ?DOMDocument $doc ) {
        if ( $doc === null ) {
            return;
        }
        $xPath = new DOMXPath( $doc );
Severity: Minor
Found in includes/Transforms/MoveLeadParagraphTransform.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function identifyInfoboxElement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function identifyInfoboxElement( DOMXPath $xPath, DOMElement $section ): ?DOMElement {
        $paths = [
            // Infoboxes: *.infobox
            './/*[contains(concat(" ",normalize-space(@class)," ")," infobox ")]',
            // Thumbnail images: .thumb, figure (Parsoid)
Severity: Minor
Found in includes/Transforms/MoveLeadParagraphTransform.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method moveFirstParagraphBeforeInfobox has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function moveFirstParagraphBeforeInfobox( DOMElement $leadSection, ?DOMDocument $doc ) {
        if ( $doc === null ) {
            return;
        }
        $xPath = new DOMXPath( $doc );
Severity: Minor
Found in includes/Transforms/MoveLeadParagraphTransform.php - About 1 hr to fix

    Method identifyInfoboxElement has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function identifyInfoboxElement( DOMXPath $xPath, DOMElement $section ): ?DOMElement {
        $paths = [
            // Infoboxes: *.infobox
            './/*[contains(concat(" ",normalize-space(@class)," ")," infobox ")]',
            // Thumbnail images: .thumb, figure (Parsoid)
    Severity: Minor
    Found in includes/Transforms/MoveLeadParagraphTransform.php - About 1 hr to fix

      Function isNonLeadParagraph has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private function isNonLeadParagraph( $xPath, $node ) {
        if (
            $node->nodeType === XML_ELEMENT_NODE &&
            /** @phan-suppress-next-line PhanUndeclaredProperty DOMNode vs. DOMElement */
            $node->tagName === 'p' &&
      Severity: Minor
      Found in includes/Transforms/MoveLeadParagraphTransform.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status