Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
includes/specials/SpecialMobileOptions.php

Summary

Maintainability
D
2 days
Test Coverage

Method addSettingsForm has 119 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addSettingsForm() {
        $out = $this->getOutput();
        $user = $this->getUser();
        $isTemp = $user->isTemp();
Severity: Major
Found in includes/specials/SpecialMobileOptions.php - About 4 hrs to fix

    File SpecialMobileOptions.php has 341 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

use MediaWiki\Config\Config;
use MediaWiki\Deferred\DeferredUpdates;
use MediaWiki\Html\Html;
    Severity: Minor
    Found in includes/specials/SpecialMobileOptions.php - About 4 hrs to fix

      Method submitSettingsForm has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function submitSettingsForm() {
        $request = $this->getRequest();
        $user = $this->getUser();

        if ( $user->isRegistered() && !$user->matchEditToken( $request->getVal( 'token' ) ) ) {
      Severity: Major
      Found in includes/specials/SpecialMobileOptions.php - About 2 hrs to fix

        Method buildAMCToggle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function buildAMCToggle() {
        $amcToggle = new OOUI\CheckboxInputWidget( [
            'name' => 'enableAMC',
            'infusable' => true,
            'selected' => $this->userMode->isEnabled(),
        Severity: Minor
        Found in includes/specials/SpecialMobileOptions.php - About 1 hr to fix

          Function addSettingsForm has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

              private function addSettingsForm() {
        $out = $this->getOutput();
        $user = $this->getUser();
        $isTemp = $user->isTemp();
          Severity: Minor
          Found in includes/specials/SpecialMobileOptions.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method buildMobileUserPreferences has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function buildMobileUserPreferences() {
        $spacer = new OOUI\LabelWidget( [
            'name' => 'mobile_preference_spacer',
        ] );
        $userPreferences = new OOUI\FieldLayout(
          Severity: Minor
          Found in includes/specials/SpecialMobileOptions.php - About 1 hr to fix

            Function submitSettingsForm has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function submitSettingsForm() {
        $request = $this->getRequest();
        $user = $this->getUser();

        if ( $user->isRegistered() && !$user->matchEditToken( $request->getVal( 'token' ) ) ) {
            Severity: Minor
            Found in includes/specials/SpecialMobileOptions.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $layout = new OOUI\FieldLayout(
            $amcToggle,
            [
                'label' => new OOUI\LabelWidget( [
                    'input' => $amcToggle,
            Severity: Major
            Found in includes/specials/SpecialMobileOptions.php and 1 other location - About 2 hrs to fix
            includes/specials/SpecialMobileOptions.php on lines 171..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $userPreferences = new OOUI\FieldLayout(
            $spacer,
            [
                'label' => new OOUI\LabelWidget( [
                    'input' => $spacer,
            Severity: Major
            Found in includes/specials/SpecialMobileOptions.php and 1 other location - About 2 hrs to fix
            includes/specials/SpecialMobileOptions.php on lines 118..135

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 130.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status