wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub

Showing 166 of 183 total issues

Method buildAMCToggle has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function buildAMCToggle() {
        $amcToggle = new OOUI\CheckboxInputWidget( [
            'name' => 'enableAMC',
            'infusable' => true,
            'selected' => $this->userMode->isEnabled(),
Severity: Minor
Found in includes/specials/SpecialMobileOptions.php - About 1 hr to fix

    Function getMobileMode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getMobileMode() {
            $enableBeta = $this->config->get( 'MFEnableBeta' );
    
            if ( !$enableBeta ) {
                return '';
    Severity: Minor
    Found in includes/MobileContext.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _enable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    Toggler.prototype._enable = function () {
        const self = this;
    
        // FIXME This should use .find() instead of .children(), some extensions like Wikibase
        // want to toggle other headlines than direct descendants of $container. (T95889)
    Severity: Minor
    Found in src/mobile.startup/Toggler.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function doRewriteImagesForLazyLoading has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        private function doRewriteImagesForLazyLoading( $el, ?DOMDocument $doc ) {
            if ( $doc === null ) {
                return;
            }
            $lazyLoadSkipSmallImages = $this->skipSmall;
    Severity: Minor
    Found in includes/Transforms/LazyImageTransform.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loadVisualEditorMaybe has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function loadVisualEditorMaybe() {
                logInit( 'visualeditor' );
                // Inform other interested code that we're loading the editor
                /**
                 * Internal for use in GrowthExperiments only.
    Severity: Minor
    Found in src/mobile.init/editor.js - About 1 hr to fix

      Function createPromoCampaign has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createPromoCampaign(
          onShow,
          actions,
          campaignName,
          campaignActive,
      Severity: Minor
      Found in src/mobile.startup/promoCampaign/promoCampaign.js - About 1 hr to fix

        Function performSearch has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            performSearch( query ) {
                const
                    self = this,
                    api = this.api,
                    delay = this.gateway.isCached( query ) ? 0 : SEARCH_DELAY;
        Severity: Minor
        Found in src/mobile.startup/search/SearchOverlay.js - About 1 hr to fix

          Function _matchRoute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              _matchRoute( path, entry ) {
                  let
                      didMatch,
                      captures,
                      match;
          Severity: Minor
          Found in src/mobile.startup/OverlayManager.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function onBeforeExit has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              onBeforeExit: function ( exit, cancel ) {
                  const self = this;
                  if ( this.hasChanged() && !this.switching ) {
                      if ( !this.windowManager ) {
                          this.windowManager = OO.ui.getWindowManager();
          Severity: Minor
          Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

            Function filterLanguages has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                filterLanguages: function ( searchQuery, searchOrigin ) {
                    const filteredList = [];
            
                    if ( searchQuery ) {
                        this.options.languages.forEach( function ( language ) {
            Severity: Minor
            Found in src/mobile.languages.structured/LanguageSearcher.js - About 1 hr to fix

              Function LanguageSearcher has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function LanguageSearcher( props ) {
                  /**
                   * @prop {StructuredLanguages} languages` JSDoc.
                   */
                  const languages = langUtil.getStructuredLanguages(
              Severity: Minor
              Found in src/mobile.languages.structured/LanguageSearcher.js - About 1 hr to fix

                Function save has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    save: function ( options ) {
                        const self = this,
                            result = util.Deferred();
                
                        options = options || {};
                Severity: Minor
                Found in src/mobile.editor.overlay/EditorGateway.js - About 1 hr to fix

                  Function _matchRoute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      _matchRoute( path, entry ) {
                          let
                              didMatch,
                              captures,
                              match;
                  Severity: Minor
                  Found in src/mobile.startup/OverlayManager.js - About 1 hr to fix

                    Function toggle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    Toggler.prototype.toggle = function ( $heading, fromSaved ) {
                        if ( !fromSaved && $heading.hasClass( 'collapsible-heading-disabled' ) ) {
                            return false;
                        }
                    
                    
                    Severity: Minor
                    Found in src/mobile.startup/Toggler.js - About 1 hr to fix

                      Function showEditNotices has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          showEditNotices: function () {
                              const overlay = this;
                              if ( mw.config.get( 'wgMFEditNoticesFeatureConflict' ) ) {
                                  return;
                              }
                      Severity: Minor
                      Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

                        Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        module.exports = function () {
                            const
                                currentPage = require( '../mobile.startup/currentPage' )(),
                                Toggler = require( '../mobile.startup/Toggler' ),
                                sectionCollapsing = require( '../mobile.startup/sectionCollapsing' ),
                        Severity: Minor
                        Found in src/mobile.init/toggling.js - About 1 hr to fix

                          Method makeSections has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function makeSections( DOMElement $body, array $headingWrappers ) {
                                  $ownerDocument = $body->ownerDocument;
                                  if ( $ownerDocument === null ) {
                                      return;
                                  }
                          Severity: Minor
                          Found in includes/Transforms/MakeSectionsTransform.php - About 1 hr to fix

                            Function showReference has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                showReference( id, page, refNumber, pageHTMLParser, gateway, props,
                                    onShowNestedReference
                                ) {
                                    return gateway.getReference( id, page, pageHTMLParser ).then( ( reference ) => {
                                        const drawer = referenceDrawer( util.extend( {
                            Severity: Minor
                            Found in src/mobile.startup/references/references.js - About 1 hr to fix

                              Function preRender has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  preRender: function () {
                                      const options = this.options;
                              
                                      this.options.headers = [
                                          headers.formHeader(
                              Severity: Minor
                              Found in src/mobile.editor.overlay/EditorOverlayBase.js - About 1 hr to fix

                                Function showLoading has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                        function showLoading() {
                                            let $sectionTop, fakeScroll, enableVisualSectionEditing;
                                
                                            $( document.body ).addClass( 've-loading' );
                                
                                
                                Severity: Minor
                                Found in src/mobile.init/editor.js - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language