Sign upLogin

wikimedia/mediawiki-extensions-MobileFrontend

View on GitHub
Star
src/mobile.startup/PageHTMLParser.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function findChildInSectionLead has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    findChildInSectionLead( sectionIndex, selector ) {
        let $heading, $nextHeading;

        const headingSelector = HEADING_SELECTOR;
Severity: Minor
Found in src/mobile.startup/PageHTMLParser.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLanguages has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getLanguages( pageTitle ) {
        const mapLinkToLanguageObj = ( node ) => {
            const DELIMITER = ' – ';
            // Name of language (e.g. עברית for Hebrew)
            const autonym = node.textContent;
Severity: Minor
Found in src/mobile.startup/PageHTMLParser.js - About 1 hr to fix

    Function findChildInSectionLead has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        findChildInSectionLead( sectionIndex, selector ) {
        let $heading, $nextHeading;

        const headingSelector = HEADING_SELECTOR;
    Severity: Minor
    Found in src/mobile.startup/PageHTMLParser.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return $heading.nextUntil( $nextHeading, selector );
      Severity: Major
      Found in src/mobile.startup/PageHTMLParser.js - About 30 mins to fix

        Function getThumbnail has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            getThumbnail( $a ) {
        const notSelector = '.' + EXCLUDE_THUMBNAIL_CLASS_SELECTORS.join( ',.' ),
            $lazyImage = $a.find( '.lazy-image-placeholder' ),
            href = $a.attr( 'href' ),
            url = href && new URL( href, location.href ),
        Severity: Minor
        Found in src/mobile.startup/PageHTMLParser.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status