Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star

Showing 1,238 of 1,238 total issues

Function getGraphData has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public function getGraphData( TranslationStatsGraphOptions $opts, Language $language ): array {
        $dbr = $this->dbProvider->getReplicaDatabase();

        $so = $this->getStatsProvider( $opts->getValue( 'count' ), $opts );
Severity: Minor
Found in src/Statistics/TranslationStatsDataProvider.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute( $parameters ) {
        $this->setHeaders();

        $user = $this->getUser();
        $request = $this->getRequest();
Severity: Major
Found in src/PageTranslation/PageTranslationSpecialPage.php - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        $( '<button>' )
                        .addClass( 'accept mw-ui-button mw-ui-progressive' )
                        .text( mw.msg( 'tsb-accept-button-label' ) )
                        .on( 'click', function () {
                            mw.notify( mw.msg( 'tsb-accept-confirmation', 1 ) );
    Severity: Major
    Found in resources/js/ext.translate.special.managetranslatorsandbox.js and 1 other location - About 4 hrs to fix
    resources/js/ext.translate.special.managetranslatorsandbox.js on lines 137..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        $( '<button>' )
                        .addClass( 'reject mw-ui-button mw-ui-destructive' )
                        .text( mw.msg( 'tsb-reject-button-label' ) )
                        .on( 'click', function () {
                            mw.notify( mw.msg( 'tsb-reject-confirmation', 1 ) );
    Severity: Major
    Found in resources/js/ext.translate.special.managetranslatorsandbox.js and 1 other location - About 4 hrs to fix
    resources/js/ext.translate.special.managetranslatorsandbox.js on lines 120..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        $( '<button>' )
                        .addClass( 'accept-all mw-ui-button mw-ui-progressive' )
                        .text( mw.msg( 'tsb-accept-all-button-label' ) )
                        .on( 'click', function () {
                            mw.notify( mw.msg( 'tsb-accept-confirmation', selectedUserIDs.length ) );
    Severity: Major
    Found in resources/js/ext.translate.special.managetranslatorsandbox.js and 1 other location - About 4 hrs to fix
    resources/js/ext.translate.special.managetranslatorsandbox.js on lines 314..330

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        $( '<button>' )
                        .addClass( 'reject-all mw-ui-button mw-ui-destructive' )
                        .text( mw.msg( 'tsb-reject-all-button-label' ) )
                        .on( 'click', function () {
                            mw.notify( mw.msg( 'tsb-reject-confirmation', selectedUserIDs.length ) );
    Severity: Major
    Found in resources/js/ext.translate.special.managetranslatorsandbox.js and 1 other location - About 4 hrs to fix
    resources/js/ext.translate.special.managetranslatorsandbox.js on lines 297..313

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File TranslateSpecialPage.php has 355 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\TranslatorInterface;
    Severity: Minor
    Found in src/TranslatorInterface/TranslateSpecialPage.php - About 4 hrs to fix

      GroupSynchronizationCache has 35 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class GroupSynchronizationCache {
    private PersistentCache $cache;
    private int $initialTimeoutSeconds;
    private int $incrementalTimeoutSeconds;
    /** @var string Cache tag used for groups */
      Severity: Minor
      Found in src/Synchronization/GroupSynchronizationCache.php - About 4 hrs to fix

        File ExportTranslationsMaintenanceScript.php has 353 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

namespace MediaWiki\Extension\Translate\Synchronization;

use FileBasedMessageGroup;
        Severity: Minor
        Found in src/Synchronization/ExportTranslationsMaintenanceScript.php - About 4 hrs to fix

          Function prepareInfoColumn has 111 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  prepareInfoColumn: function () {
            var $infoColumn = $( '<div>' ).addClass( 'infocolumn' ),
                translateEditor = this;

            $infoColumn.append( $( '<div>' )
          Severity: Major
          Found in resources/js/ext.translate.editor.js - About 4 hrs to fix

            Method run has 111 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function run( ApiPageSet $resultPageSet = null ): void {
        $params = $this->extractRequestParams();

        $group = MessageGroups::getGroup( $params['group'] );
        if ( !$group ) {
            Severity: Major
            Found in src/MessageLoading/QueryMessageCollectionActionApi.php - About 4 hrs to fix

              Function parse has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function parse() {
        $data = file_get_contents( $this->file );
        $data = TextContent::normalizeLineEndings( $data );

        $matches = [];
              Severity: Minor
              Found in scripts/poimport.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File GroupSynchronizationCache.php has 348 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\Synchronization;
              Severity: Minor
              Found in src/Synchronization/GroupSynchronizationCache.php - About 4 hrs to fix

                MessageSourceChange has 34 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class MessageSourceChange {
    /**
     * @var array[][][]
     * @phpcs:ignore Generic.Files.LineLength
     * @phan-var array<string,array<string,array<string|int,array{key:string,content:string,similarity?:float,matched_to?:string,previous_state?:string}>>>
                Severity: Minor
                Found in src/MessageSync/MessageSourceChange.php - About 4 hrs to fix

                  File LanguageStatsSpecialPage.php has 346 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\Statistics;
                  Severity: Minor
                  Found in src/Statistics/LanguageStatsSpecialPage.php - About 4 hrs to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        $.fn.messagetable = function ( options ) {
        return this.each( function () {
            var $this = $( this ),
                data = $this.data( 'messagetable' );
                    Severity: Major
                    Found in resources/js/ext.translate.messagetable.js and 1 other location - About 4 hrs to fix
                    resources/js/ext.translate.editor.js on lines 1526..1541

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 121.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        $.fn.translateeditor = function ( options ) {
        return this.each( function () {
            var $this = $( this ),
                data = $this.data( 'translateeditor' );
                    Severity: Major
                    Found in resources/js/ext.translate.editor.js and 1 other location - About 4 hrs to fix
                    resources/js/ext.translate.messagetable.js on lines 846..859

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 121.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Method languages has 107 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function languages( $data, $params, $parser ) {
        global $wgPageTranslationLanguageList;

        if ( $wgPageTranslationLanguageList === 'sidebar-only' ) {
            return '';
                    Severity: Major
                    Found in src/PageTranslation/Hooks.php - About 4 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      $specialPageAliases['sr-el'] = [
    'AggregateGroups' => [ 'Spojene_grupe' ],
    'ImportTranslations' => [ 'Uvoz_prevoda' ],
    'ExportTranslations' => [ 'Izvoz_prevoda' ],
    'LanguageStats' => [ 'Statistika_jezika' ],
                      Severity: Major
                      Found in Translate.alias.php and 1 other location - About 4 hrs to fix
                      Translate.alias.php on lines 935..953

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 168.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      $specialPageAliases['sr-ec'] = [
    'AggregateGroups' => [ 'Спојене_групе' ],
    'ImportTranslations' => [ 'Увоз_превода' ],
    'ExportTranslations' => [ 'Извоз_превода' ],
    'LanguageStats' => [ 'Статистика_језика' ],
                      Severity: Major
                      Found in Translate.alias.php and 1 other location - About 4 hrs to fix
                      Translate.alias.php on lines 956..974

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 168.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language