Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/FileFormatSupport/AndroidXmlFormat.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method writeReal has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function writeReal( MessageCollection $collection ): string {
        global $wgTranslateDocumentationLanguageCode;

        $collection->filter( 'hastranslation', false );
        if ( count( $collection ) === 0 ) {
Severity: Minor
Found in src/FileFormatSupport/AndroidXmlFormat.php - About 1 hr to fix

    Function writeReal has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function writeReal( MessageCollection $collection ): string {
        global $wgTranslateDocumentationLanguageCode;

        $collection->filter( 'hastranslation', false );
        if ( count( $collection ) === 0 ) {
    Severity: Minor
    Found in src/FileFormatSupport/AndroidXmlFormat.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function readFromVariable has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function readFromVariable( string $data ): array {
        $reader = new SimpleXMLElement( $data );

        $messages = [];
        $mangler = $this->group->getMangler();
    Severity: Minor
    Found in src/FileFormatSupport/AndroidXmlFormat.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method readFromVariable has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function readFromVariable( string $data ): array {
        $reader = new SimpleXMLElement( $data );

        $messages = [];
        $mangler = $this->group->getMangler();
    Severity: Minor
    Found in src/FileFormatSupport/AndroidXmlFormat.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status