Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageBundleTranslation/Hooks.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method onPageSaveComplete has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function onPageSaveComplete(
        $wikiPage,
        $user,
        $summary,
        $flags,
Severity: Minor
Found in src/MessageBundleTranslation/Hooks.php - About 1 hr to fix

    Method onArticleViewHeader has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function onArticleViewHeader( $article, &$outputDone, &$pcache ) {
        if ( !$this->enableIntegration ) {
            return;
        }
    Severity: Minor
    Found in src/MessageBundleTranslation/Hooks.php - About 1 hr to fix

      Method onEditFilterMergedContent has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              IContextSource $context,
        Content $content,
        Status $status,
        $summary,
        User $user,
      Severity: Minor
      Found in src/MessageBundleTranslation/Hooks.php - About 45 mins to fix

        Function onPageSaveComplete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function onPageSaveComplete(
        $wikiPage,
        $user,
        $summary,
        $flags,
        Severity: Minor
        Found in src/MessageBundleTranslation/Hooks.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                LoggerInterface $logger,
        MessageBundleStore $messageBundleStore,
        LinkRenderer $linkRenderer,
        TitleFactory $titleFactory,
        JobQueueGroup $jobQueueGroup,
        Severity: Minor
        Found in src/MessageBundleTranslation/Hooks.php - About 45 mins to fix

          Method onPageSaveComplete has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $wikiPage,
        $user,
        $summary,
        $flags,
        $revisionRecord,
          Severity: Minor
          Found in src/MessageBundleTranslation/Hooks.php - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                        return;
            Severity: Major
            Found in src/MessageBundleTranslation/Hooks.php - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status