Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageBundleTranslation/MessageBundleStore.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function validate has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate( Title $pageTitle, MessageBundleContent $content ): void {
        $content->validate();
        // Verify that the language code is valid
        $metadata = $content->getMetadata();
        $sourceLanguageCode = $metadata->getSourceLanguageCode();
Severity: Minor
Found in src/MessageBundleTranslation/MessageBundleStore.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save(
        Title $pageTitle,
        RevisionRecord $revisionRecord,
        MessageBundleContent $content
    ): void {
Severity: Minor
Found in src/MessageBundleTranslation/MessageBundleStore.php - About 1 hr to fix

    Method validate has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function validate( Title $pageTitle, MessageBundleContent $content ): void {
        $content->validate();
        // Verify that the language code is valid
        $metadata = $content->getMetadata();
        $sourceLanguageCode = $metadata->getSourceLanguageCode();
    Severity: Minor
    Found in src/MessageBundleTranslation/MessageBundleStore.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              RevTagStore $revTagStore,
        JobQueueGroup $jobQueue,
        LanguageNameUtils $languageNameUtils,
        MessageIndex $messageIndex,
        MessageGroupMetadata $messageGroupMetadata
      Severity: Minor
      Found in src/MessageBundleTranslation/MessageBundleStore.php - About 35 mins to fix

        Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function save(
        Title $pageTitle,
        RevisionRecord $revisionRecord,
        MessageBundleContent $content
    ): void {
        Severity: Minor
        Found in src/MessageBundleTranslation/MessageBundleStore.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status