Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageGroupProcessing/AggregateGroupsActionApi.php

Summary

Maintainability
D
2 days
Test Coverage

Function execute has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(): void {
        $this->checkUserRightsAny( self::$right );
        $block = $this->getUser()->getBlock();
        if ( $block && $block->isSitewide() ) {
            $this->dieBlocked( $block );
Severity: Minor
Found in src/MessageGroupProcessing/AggregateGroupsActionApi.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 174 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(): void {
        $this->checkUserRightsAny( self::$right );
        $block = $this->getUser()->getBlock();
        if ( $block && $block->isSitewide() ) {
            $this->dieBlocked( $block );
Severity: Major
Found in src/MessageGroupProcessing/AggregateGroupsActionApi.php - About 6 hrs to fix

    File AggregateGroupsActionApi.php has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\MessageGroupProcessing;
    Severity: Minor
    Found in src/MessageGroupProcessing/AggregateGroupsActionApi.php - About 2 hrs to fix

      Method getAllowedParams has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getAllowedParams(): array {
        return [
            'do' => [
                ParamValidator::PARAM_TYPE => [ 'associate', 'dissociate', 'remove', 'add', 'update' ],
                ParamValidator::PARAM_REQUIRED => true,
      Severity: Minor
      Found in src/MessageGroupProcessing/AggregateGroupsActionApi.php - About 1 hr to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ApiMain $main,
        string $action,
        JobQueueGroup $jobQueueGroup,
        MessageGroupMetadata $messageGroupMetadata,
        AggregateGroupManager $aggregateGroupManager
        Severity: Minor
        Found in src/MessageGroupProcessing/AggregateGroupsActionApi.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status