Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageGroupProcessing/AggregateGroupsSpecialPage.php

Summary

Maintainability
C
1 day
Test Coverage

Method showAggregateGroup has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function showAggregateGroup( AggregateMessageGroup $group ): string {
        $id = $group->getId();
        $label = $group->getLabel();
        $desc = $group->getDescription( $this->getContext() );
        $sourceLanguage = $this->messageGroupMetadata->get( $id, 'sourcelanguagecode' );
Severity: Major
Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 3 hrs to fix

    File AggregateGroupsSpecialPage.php has 271 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\MessageGroupProcessing;
    Severity: Minor
    Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 2 hrs to fix

      Method showAggregateGroups has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function showAggregateGroups( array $aggregates ): void {
        $out = $this->getOutput();
        $out->addModules( 'ext.translate.special.aggregategroups' );

        $nojs = Html::errorBox(
      Severity: Major
      Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 2 hrs to fix

        Method listSubgroups has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function listSubgroups( string $groupId, array $subGroupIds ): string {
        $id = $this->htmlIdForGroup( $groupId, 'mw-tpa-grouplist-' );
        $out = Html::openElement( 'ol', [ 'id' => $id ] );

        // Get the respective groups and sort them
        Severity: Minor
        Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 1 hr to fix

          Method execute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function execute( $parameters ): void {
        $this->setHeaders();
        $this->addHelpLink( 'Help:Extension:Translate/Page translation administration' );

        $out = $this->getOutput();
          Severity: Minor
          Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 1 hr to fix

            Function listSubgroups has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function listSubgroups( string $groupId, array $subGroupIds ): string {
        $id = $this->htmlIdForGroup( $groupId, 'mw-tpa-grouplist-' );
        $out = Html::openElement( 'ol', [ 'id' => $id ] );

        // Get the respective groups and sort them
            Severity: Minor
            Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function execute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function execute( $parameters ): void {
        $this->setHeaders();
        $this->addHelpLink( 'Help:Extension:Translate/Page translation administration' );

        $out = $this->getOutput();
            Severity: Minor
            Found in src/MessageGroupProcessing/AggregateGroupsSpecialPage.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status