Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageGroupProcessing/ManageMessageGroupsActionApi.php

Summary

Maintainability
C
1 day
Test Coverage

Method execute has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(): void {
        $this->checkUserRightsAny( self::RIGHT );
        $params = $this->extractRequestParams();

        $groupId = $params['groupId'];
Severity: Major
Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 2 hrs to fix

    Method handleRename has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function handleRename(
        MessageGroup $group,
        MessageSourceChange $sourceChanges,
        string $msgKey,
        string $keyToRename,
    Severity: Major
    Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 2 hrs to fix

      Function handleRename has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function handleRename(
        MessageGroup $group,
        MessageSourceChange $sourceChanges,
        string $msgKey,
        string $keyToRename,
      Severity: Minor
      Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handleSourceRename has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function handleSourceRename(
        MessageSourceChange $sourceChanges,
        string $code,
        string $msgKey,
        string $keyToRename
      Severity: Minor
      Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute(): void {
        $this->checkUserRightsAny( self::RIGHT );
        $params = $this->extractRequestParams();

        $groupId = $params['groupId'];
        Severity: Minor
        Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getAllowedParams has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function getAllowedParams(): array {
        return [
            'groupId' => [
                ParamValidator::PARAM_TYPE => 'string',
                ParamValidator::PARAM_REQUIRED => true,
        Severity: Minor
        Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 1 hr to fix

          Function handleNew has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function handleNew(
        MessageSourceChange $sourceChanges,
        string $msgKey,
        string $sourceLang
    ): void {
          Severity: Minor
          Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method handleRename has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  MessageGroup $group,
        MessageSourceChange $sourceChanges,
        string $msgKey,
        string $keyToRename,
        string $sourceLanguage
          Severity: Minor
          Found in src/MessageGroupProcessing/ManageMessageGroupsActionApi.php - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status