Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageGroupProcessing/MessageGroupSubscription.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function sendNotifications has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    public function sendNotifications( array $changesToProcess ): void {
        if ( !$this->isEnabled() || $changesToProcess === [] ) {
            return;
        }
Severity: Minor
Found in src/MessageGroupProcessing/MessageGroupSubscription.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sendNotifications has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendNotifications( array $changesToProcess ): void {
        if ( !$this->isEnabled() || $changesToProcess === [] ) {
            return;
        }
Severity: Major
Found in src/MessageGroupProcessing/MessageGroupSubscription.php - About 2 hrs to fix

    Function getMappedAggregateGroupIds has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getMappedAggregateGroupIds(): array {
        $groupStructure = MessageGroups::getGroupStructure();
        // Flatten the group structure for easy indexing
        $groupIdAggregateMapped = [];
        foreach ( $groupStructure as $groupId => $mappedGroups ) {
    Severity: Minor
    Found in src/MessageGroupProcessing/MessageGroupSubscription.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            MessageGroupSubscriptionStore $groupSubscriptionStore,
        JobQueueGroup $jobQueueGroup,
        UserIdentityLookup $userIdentityLookup,
        LoggerInterface $logger,
        ServiceOptions $options
    Severity: Minor
    Found in src/MessageGroupProcessing/MessageGroupSubscription.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status