Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageGroupProcessing/QueryMessageGroupsActionApi.php

Summary

Maintainability
D
1 day
Test Coverage

Function execute has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(): void {
        $params = $this->extractRequestParams();
        $filter = $params['filter'];

        $groups = [];
Severity: Minor
Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function formatGroup has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    protected function formatGroup( $mixed, array $props, int $depth = 0 ): array {
        $params = $this->extractRequestParams();
        $context = $this->getContext();

        // Default
Severity: Minor
Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method formatGroup has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function formatGroup( $mixed, array $props, int $depth = 0 ): array {
        $params = $this->extractRequestParams();
        $context = $this->getContext();

        // Default
Severity: Major
Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 2 hrs to fix

    Method execute has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute(): void {
        $params = $this->extractRequestParams();
        $filter = $params['filter'];

        $groups = [];
    Severity: Major
    Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 2 hrs to fix

      Function getWorkflowStates has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getWorkflowStates( MessageGroup $group ) {
        if ( MessageGroups::isDynamic( $group ) ) {
            return false;
        }
      Severity: Minor
      Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getAllowedParams has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getAllowedParams(): array {
        $allowedParams = [
            'depth' => [
                ParamValidator::PARAM_TYPE => 'integer',
                ParamValidator::PARAM_DEFAULT => 100,
      Severity: Minor
      Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 1 hr to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                ApiQuery $query,
        string $moduleName,
        HookRunner $hookRunner,
        MessageGroupMetadata $messageGroupMetadata,
        MessageGroupSubscription $groupSubscription
        Severity: Minor
        Found in src/MessageGroupProcessing/QueryMessageGroupsActionApi.php - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status