Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageGroupProcessing/TranslatablePageStore.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        MessageIndex $messageIndex,
        JobQueueGroup $jobQueue,
        RevTagStore $revTagStore,
        IConnectionProvider $dbProvider,
        TranslatableBundleStatusStore $translatableBundleStatusStore,
Severity: Major
Found in src/MessageGroupProcessing/TranslatablePageStore.php - About 50 mins to fix

    Function moveMetadata has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private function moveMetadata( string $oldGroupId, string $newGroupId ): void {
        // Make the changes in aggregate groups metadata, if present in any of them.
        $aggregateGroups = MessageGroups::getGroupsByType( AggregateMessageGroup::class );
        $this->messageGroupMetadata->preloadGroups( array_keys( $aggregateGroups ), __METHOD__ );
    Severity: Minor
    Found in src/MessageGroupProcessing/TranslatablePageStore.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function removeFromAggregateGroups has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function removeFromAggregateGroups( string $groupId ): void {
        // remove the page from aggregate groups, if present in any of them.
        $aggregateGroups = MessageGroups::getGroupsByType( AggregateMessageGroup::class );
        $this->messageGroupMetadata->preloadGroups( array_keys( $aggregateGroups ), __METHOD__ );
        foreach ( $aggregateGroups as $group ) {
    Severity: Minor
    Found in src/MessageGroupProcessing/TranslatablePageStore.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status