Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/MessageProcessing/ArrayFlattener.php

Summary

Maintainability
C
1 day
Test Coverage

Function unflatten has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function unflatten( array $flat ): array {
        $unflat = [];

        if ( $this->parseCLDRPlurals ) {
            $unflattenedPlurals = [];
Severity: Minor
Found in src/MessageProcessing/ArrayFlattener.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function unflattenCLDRPlurals has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function unflattenCLDRPlurals( string $key, string $message ) {
        // Quick escape.
        if ( !str_contains( $message, '{{PLURAL' ) ) {
            return false;
        }
Severity: Minor
Found in src/MessageProcessing/ArrayFlattener.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method unflattenCLDRPlurals has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function unflattenCLDRPlurals( string $key, string $message ) {
        // Quick escape.
        if ( !str_contains( $message, '{{PLURAL' ) ) {
            return false;
        }
Severity: Major
Found in src/MessageProcessing/ArrayFlattener.php - About 2 hrs to fix

    Function flattenCLDRPlurals has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function flattenCLDRPlurals( array $messages ) {
        $hasNonPluralKeys = false;
        $pluralKeys = [];
        foreach ( $messages as $key => $value ) {
            if ( is_array( $value ) ) {
    Severity: Minor
    Found in src/MessageProcessing/ArrayFlattener.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function flatten has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function flatten( array $unflat ): array {
        $flat = [];

        foreach ( $unflat as $key => $value ) {
            if ( !is_array( $value ) ) {
    Severity: Minor
    Found in src/MessageProcessing/ArrayFlattener.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unflatten has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function unflatten( array $flat ): array {
        $unflat = [];

        if ( $this->parseCLDRPlurals ) {
            $unflattenedPlurals = [];
    Severity: Minor
    Found in src/MessageProcessing/ArrayFlattener.php - About 1 hr to fix

      Method flattenCLDRPlurals has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function flattenCLDRPlurals( array $messages ) {
        $hasNonPluralKeys = false;
        $pluralKeys = [];
        foreach ( $messages as $key => $value ) {
            if ( is_array( $value ) ) {
      Severity: Minor
      Found in src/MessageProcessing/ArrayFlattener.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status