Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php

Summary

Maintainability
C
1 day
Test Coverage

File ManageMessageGroupSubscriptionsSpecialPage.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\PageTranslation;
Severity: Minor
Found in src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php - About 2 hrs to fix

    Method submitRaw has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function submitRaw( array $data ): bool {
        $retainedLines = trim( $data['Titles'] );
        $retainedGroups = $retainedLines ? array_map( 'trim', explode( "\n", $retainedLines ) ) : [];
        $current = $this->messageGroupSubscription->getUserSubscriptions( $this->getUser() );
    Severity: Minor
    Found in src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php - About 1 hr to fix

      Method getNormalForm has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getNormalForm(): HTMLForm {
        $fields = [];

        // Allow subscribers to manipulate the list of watched pages (or use it
        // to preload lots of details at once)
      Severity: Minor
      Found in src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php - About 1 hr to fix

        Method showTitles has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function showTitles( array $messageGroupsIds ): string {
        if ( count( $messageGroupsIds ) >= 100 ) {
            return $this->msg( 'tpt-manage-message-group-subscriptions-too-many' )->parse();
        }
        Severity: Minor
        Found in src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php - About 1 hr to fix

          Function getNormalForm has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getNormalForm(): HTMLForm {
        $fields = [];

        // Allow subscribers to manipulate the list of watched pages (or use it
        // to preload lots of details at once)
          Severity: Minor
          Found in src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function showTitles has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private function showTitles( array $messageGroupsIds ): string {
        if ( count( $messageGroupsIds ) >= 100 ) {
            return $this->msg( 'tpt-manage-message-group-subscriptions-too-many' )->parse();
        }
          Severity: Minor
          Found in src/PageTranslation/ManageMessageGroupSubscriptionsSpecialPage.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status