Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/PageTranslation/TranslatablePage.php

Summary

Maintainability
C
1 day
Test Coverage

File TranslatablePage.php has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\PageTranslation;
Severity: Minor
Found in src/PageTranslation/TranslatablePage.php - About 5 hrs to fix

    TranslatablePage has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class TranslatablePage extends TranslatableBundle {
    /**
     * List of keys in the metadata table that need to be handled for moves and deletions
     * @phpcs-require-sorted-array
     */
    Severity: Minor
    Found in src/PageTranslation/TranslatablePage.php - About 4 hrs to fix

      Method isSourcePage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function isSourcePage( PageIdentity $page ): bool {
        if ( !$page->exists() ) {
            // No point in loading all translatable pages if the page
            // doesn’t exist. This also avoids PreconditionExceptions
            // if $page is a Title pointing to a non-proper page like
      Severity: Minor
      Found in src/PageTranslation/TranslatablePage.php - About 1 hr to fix

        Function determineStatus has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function determineStatus(
        ?int $readyRevisionId,
        ?int $markRevisionId,
        int $latestRevisionId
    ): ?TranslatablePageStatus {
        Severity: Minor
        Found in src/PageTranslation/TranslatablePage.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status