Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/RecentChangesTranslationFilterHookHandler.php

Summary

Maintainability
C
1 day
Test Coverage

Method onChangesListSpecialPageStructuredFilters has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function onChangesListSpecialPageStructuredFilters( $special ): void {
        $translateRcFilterDefault = $this->config->get( 'TranslateRcFilterDefault' );
        $defaultFilter = $translateRcFilterDefault !== 'noaction' ?
            $translateRcFilterDefault :
            ChangesListStringOptionsFilterGroup::NONE;
Severity: Major
Found in src/RecentChangesTranslationFilterHookHandler.php - About 5 hrs to fix

    Function onChangesListSpecialPageStructuredFilters has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function onChangesListSpecialPageStructuredFilters( $special ): void {
        $translateRcFilterDefault = $this->config->get( 'TranslateRcFilterDefault' );
        $defaultFilter = $translateRcFilterDefault !== 'noaction' ?
            $translateRcFilterDefault :
            ChangesListStringOptionsFilterGroup::NONE;
    Severity: Minor
    Found in src/RecentChangesTranslationFilterHookHandler.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onChangesListSpecialPageQuery has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $pageName,
        &$tables,
        &$fields,
        &$conds,
        &$query_options,
    Severity: Major
    Found in src/RecentChangesTranslationFilterHookHandler.php - About 50 mins to fix

      Avoid too many return statements within this method.
      Open

                              return;
      Severity: Major
      Found in src/RecentChangesTranslationFilterHookHandler.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return;
        Severity: Major
        Found in src/RecentChangesTranslationFilterHookHandler.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return;
          Severity: Major
          Found in src/RecentChangesTranslationFilterHookHandler.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return;
            Severity: Major
            Found in src/RecentChangesTranslationFilterHookHandler.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return;
              Severity: Major
              Found in src/RecentChangesTranslationFilterHookHandler.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return;
                Severity: Major
                Found in src/RecentChangesTranslationFilterHookHandler.php - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                      [
                        'name' => 'only',
                        'label' => 'translate-rcfilters-translations-only-label',
                        'description' => 'translate-rcfilters-translations-only-desc',
                        'cssClassSuffix' => 'only',
                  Severity: Minor
                  Found in src/RecentChangesTranslationFilterHookHandler.php and 1 other location - About 55 mins to fix
                  src/RecentChangesTranslationFilterHookHandler.php on lines 162..173

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                      [
                        'name' => 'site',
                        'label' => 'translate-rcfilters-translations-site-label',
                        'description' => 'translate-rcfilters-translations-site-desc',
                        'cssClassSuffix' => 'site',
                  Severity: Minor
                  Found in src/RecentChangesTranslationFilterHookHandler.php and 1 other location - About 55 mins to fix
                  src/RecentChangesTranslationFilterHookHandler.php on lines 150..161

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status