Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/Synchronization/DisplayGroupSynchronizationInfo.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method getMessageInfoHtml has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getMessageInfoHtml( MessageUpdateParameter $message, Language $language ): string {
        $output = Html::openElement( 'dl' );

        $tags = [];
        if ( $message->isFuzzy() ) {
Severity: Minor
Found in src/Synchronization/DisplayGroupSynchronizationInfo.php - About 1 hr to fix

    Method getHtmlForGroupErrors has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getHtmlForGroupErrors(
        GroupSynchronizationResponse $groupErrorResponse,
        Language $language,
        string $wrapperClass
    ): string {
    Severity: Minor
    Found in src/Synchronization/DisplayGroupSynchronizationInfo.php - About 1 hr to fix

      Method getErrorMessageHtml has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getErrorMessageHtml(
        string $groupId,
        MessageUpdateParameter $message,
        Language $language,
        string $wrapperClass
      Severity: Minor
      Found in src/Synchronization/DisplayGroupSynchronizationInfo.php - About 1 hr to fix

        Method getGroupSyncInfoHtml has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $className,
        string $summaryMsgKey,
        string $descriptionMsgKey,
        string $htmlContent,
        string $preHtmlContent = null
        Severity: Minor
        Found in src/Synchronization/DisplayGroupSynchronizationInfo.php - About 35 mins to fix

          Function getMessageInfoHtml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getMessageInfoHtml( MessageUpdateParameter $message, Language $language ): string {
        $output = Html::openElement( 'dl' );

        $tags = [];
        if ( $message->isFuzzy() ) {
          Severity: Minor
          Found in src/Synchronization/DisplayGroupSynchronizationInfo.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status