Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/Synchronization/ImportExternalTranslationsMaintenanceScript.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method execute has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $name = $this->getOption( 'name', MessageChangeStorage::DEFAULT_NAME );
        if ( !MessageChangeStorage::isValidCdbName( $name ) ) {
            $this->fatalError( 'Invalid name' );
        }
Severity: Minor
Found in src/Synchronization/ImportExternalTranslationsMaintenanceScript.php - About 1 hr to fix

    Method __construct has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct() {
        parent::__construct();
        $this->addDescription( 'Script for processing message changes in file based message groups' );
        $this->addOption(
            'group',
    Severity: Minor
    Found in src/Synchronization/ImportExternalTranslationsMaintenanceScript.php - About 1 hr to fix

      Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute() {
        $name = $this->getOption( 'name', MessageChangeStorage::DEFAULT_NAME );
        if ( !MessageChangeStorage::isValidCdbName( $name ) ) {
            $this->fatalError( 'Invalid name' );
        }
      Severity: Minor
      Found in src/Synchronization/ImportExternalTranslationsMaintenanceScript.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status