Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/Synchronization/UpdateMessageJob.php

Summary

Maintainability
D
2 days
Test Coverage

Function handleFuzzy has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    private function handleFuzzy( Title $title, bool $invalidate, PageUpdater $updater, int $baseTranver ): void {
        global $wgTranslateDocumentationLanguageCode;
        $editResult = $updater->getEditResult();
        if ( !$invalidate && !$editResult->isExactRevert() ) {
            return;
Severity: Minor
Found in src/Synchronization/UpdateMessageJob.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handleFuzzy has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function handleFuzzy( Title $title, bool $invalidate, PageUpdater $updater, int $baseTranver ): void {
        global $wgTranslateDocumentationLanguageCode;
        $editResult = $updater->getEditResult();
        if ( !$invalidate && !$editResult->isExactRevert() ) {
            return;
Severity: Major
Found in src/Synchronization/UpdateMessageJob.php - About 3 hrs to fix

    File UpdateMessageJob.php has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
declare( strict_types = 1 );

namespace MediaWiki\Extension\Translate\Synchronization;
    Severity: Minor
    Found in src/Synchronization/UpdateMessageJob.php - About 3 hrs to fix

      Method handleRename has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function handleRename( string $target, string $replacement ): ?Title {
        $newSourceTitle = null;

        $sourceMessageHandle = new MessageHandle( $this->title );
        $movableTitles = TranslateReplaceTitle::getTitlesForMove( $sourceMessageHandle, $replacement );
      Severity: Minor
      Found in src/Synchronization/UpdateMessageJob.php - About 1 hr to fix

        Method run has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run(): bool {
        $params = $this->params;
        $isRename = $params['rename'] ?? false;
        $isFuzzy = $params['fuzzy'] ?? false;
        $otherLangs = $params['otherLangs'] ?? [];
        Severity: Minor
        Found in src/Synchronization/UpdateMessageJob.php - About 1 hr to fix

          Method removeFromCache has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function removeFromCache( Title $title ): void {
        $config = MediaWikiServices::getInstance()->getMainConfig();

        if ( !$config->get( 'TranslateGroupSynchronizationCache' ) ) {
            return;
          Severity: Minor
          Found in src/Synchronization/UpdateMessageJob.php - About 1 hr to fix

            Function handleRename has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private function handleRename( string $target, string $replacement ): ?Title {
        $newSourceTitle = null;

        $sourceMessageHandle = new MessageHandle( $this->title );
        $movableTitles = TranslateReplaceTitle::getTitlesForMove( $sourceMessageHandle, $replacement );
            Severity: Minor
            Found in src/Synchronization/UpdateMessageJob.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method newRenameJob has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    Title $target,
        string $targetStr,
        string $replacement,
        $fuzzy,
        string $content,
            Severity: Minor
            Found in src/Synchronization/UpdateMessageJob.php - About 45 mins to fix

              Function removeFromCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function removeFromCache( Title $title ): void {
        $config = MediaWikiServices::getInstance()->getMainConfig();

        if ( !$config->get( 'TranslateGroupSynchronizationCache' ) ) {
            return;
              Severity: Minor
              Found in src/Synchronization/UpdateMessageJob.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status