Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/TranslatorInterface/TranslateEditAddons.php

Summary

Maintainability
C
1 day
Test Coverage

Method onSaveComplete has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function onSaveComplete(
        WikiPage $wikiPage,
        UserIdentity $userIdentity,
        string $summary,
        int $flags,
Severity: Major
Found in src/TranslatorInterface/TranslateEditAddons.php - About 2 hrs to fix

    Function onSaveComplete has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function onSaveComplete(
        WikiPage $wikiPage,
        UserIdentity $userIdentity,
        string $summary,
        int $flags,
    Severity: Minor
    Found in src/TranslatorInterface/TranslateEditAddons.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method disallowLangTranslations has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function disallowLangTranslations(
        Title $title,
        User $user,
        string $action,
        &$result
    Severity: Minor
    Found in src/TranslatorInterface/TranslateEditAddons.php - About 1 hr to fix

      Function disallowLangTranslations has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function disallowLangTranslations(
        Title $title,
        User $user,
        string $action,
        &$result
      Severity: Minor
      Found in src/TranslatorInterface/TranslateEditAddons.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method onSaveComplete has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              WikiPage $wikiPage,
        UserIdentity $userIdentity,
        string $summary,
        int $flags,
        RevisionRecord $revisionRecord,
      Severity: Minor
      Found in src/TranslatorInterface/TranslateEditAddons.php - About 45 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/TranslatorInterface/TranslateEditAddons.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return false;
          Severity: Major
          Found in src/TranslatorInterface/TranslateEditAddons.php - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status