Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/TranslatorSandbox/TranslationStashActionApi.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function execute has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(): void {
        $params = $this->extractRequestParams();

        // The user we are operating on, not necessarily the user making the request
        $user = $this->getUser();
Severity: Minor
Found in src/TranslatorSandbox/TranslationStashActionApi.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(): void {
        $params = $this->extractRequestParams();

        // The user we are operating on, not necessarily the user making the request
        $user = $this->getUser();
Severity: Minor
Found in src/TranslatorSandbox/TranslationStashActionApi.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            ApiMain $mainModule,
        string $moduleName,
        IConnectionProvider $dbProvider,
        UserFactory $userFactory,
        MessageIndex $messageIndex
    Severity: Minor
    Found in src/TranslatorSandbox/TranslationStashActionApi.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status