Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/TtmServer/TtmServerFactory.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function getWritable has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function getWritable(): array {
        $writableServers = $readOnlyServers = [];
        $ttmServerIds = $this->getNames();

        foreach ( $ttmServerIds as $serverId ) {
Severity: Minor
Found in src/TtmServer/TtmServerFactory.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getNames has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function getNames(): array {
        $ttmServersIds = [];
        foreach ( $this->configs as $serviceId => $config ) {
            $type = $config['type'] ?? '';
            if ( $type === 'ttmserver' || $type === 'remote-ttmserver' ) {
Severity: Minor
Found in src/TtmServer/TtmServerFactory.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getWritable has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getWritable(): array {
        $writableServers = $readOnlyServers = [];
        $ttmServerIds = $this->getNames();

        foreach ( $ttmServerIds as $serverId ) {
Severity: Minor
Found in src/TtmServer/TtmServerFactory.php - About 1 hr to fix

    Function create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function create( string $name ): TtmServer {
        if ( !$this->has( $name ) ) {
            throw new ServiceCreationFailure( "No configuration for name '$name'" );
        }
    Severity: Minor
    Found in src/TtmServer/TtmServerFactory.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getWriteOnly has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getWriteOnly(): array {
        $ttmServerIds = $this->getNames();
        $writableServers = [];
        foreach ( $ttmServerIds as $serverId ) {
            if ( $this->configs[ $serverId ][ 'writable' ] ?? false ) {
    Severity: Minor
    Found in src/TtmServer/TtmServerFactory.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status