Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/TtmServer/TtmServerMessageUpdateJob.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method requeueError has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function requeueError( string $serviceName, Exception $e ): void {
        $this->logger->warning(
            'Exception thrown while running {command} on ' .
            'service {service}: {errorMessage}',
            [
Severity: Minor
Found in src/TtmServer/TtmServerMessageUpdateJob.php - About 1 hr to fix

    Method getServersToUpdate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getServersToUpdate( ?string $requestedServiceId ): array {
        $ttmServerFactory = Services::getInstance()->getTtmServerFactory();
        if ( $requestedServiceId ) {
            if ( !$ttmServerFactory->has( $requestedServiceId ) ) {
                $this->logger->warning(
    Severity: Minor
    Found in src/TtmServer/TtmServerMessageUpdateJob.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return [];
      Severity: Major
      Found in src/TtmServer/TtmServerMessageUpdateJob.php - About 30 mins to fix

        Function getServersToUpdate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getServersToUpdate( ?string $requestedServiceId ): array {
        $ttmServerFactory = Services::getInstance()->getTtmServerFactory();
        if ( $requestedServiceId ) {
            if ( !$ttmServerFactory->has( $requestedServiceId ) ) {
                $this->logger->warning(
        Severity: Minor
        Found in src/TtmServer/TtmServerMessageUpdateJob.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status