Sign upLogin

wikimedia/mediawiki-extensions-Translate

View on GitHub
Star
src/Validation/Validators/GettextPluralValidator.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getIssues has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getIssues( Message $message, string $targetLanguage ): ValidationIssues {
        $issues = new ValidationIssues();

        $pluralRule = GettextPlural::getPluralRule( $targetLanguage );
        // Skip validation for languages for which we do not know the plural rule
Severity: Minor
Found in src/Validation/Validators/GettextPluralValidator.php - About 1 hr to fix

    Function pluralPresenceCheck has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function pluralPresenceCheck(
        $definitionHasPlural,
        $translationHasPlural,
        $expectedPluralCount
    ) {
    Severity: Minor
    Found in src/Validation/Validators/GettextPluralValidator.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return 'ok';
    Severity: Major
    Found in src/Validation/Validators/GettextPluralValidator.php - About 30 mins to fix

      Function getIssues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getIssues( Message $message, string $targetLanguage ): ValidationIssues {
        $issues = new ValidationIssues();

        $pluralRule = GettextPlural::getPluralRule( $targetLanguage );
        // Skip validation for languages for which we do not know the plural rule
      Severity: Minor
      Found in src/Validation/Validators/GettextPluralValidator.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status