wikimedia/mediawiki-extensions-TwnMainPage

View on GitHub

Showing 35 of 35 total issues

Method searchBar has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function searchBar() {
        $out = Html::openElement( 'form',
            [
                'class' => 'row twn-mainpage-search',
                'action' => SpecialPage::getTitleFor( 'SearchTranslations' )->getLocalURL(),
Severity: Minor
Found in includes/specials/SpecialTwnMainPage.php - About 1 hr to fix

    Method getStatsTiles has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getStatsTiles( $stats ) {
            $data = [
                // Rows X cols
                [
                    [
    Severity: Minor
    Found in includes/specials/SpecialTwnMainPage.php - About 1 hr to fix

      Method footer has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function footer() {
              $out = Html::openElement( 'footer' );
              $out .= Html::openElement( 'div', [ 'class' => 'row twn-mainpage-footer' ] );
              $out .= Html::element( 'a', [
                  'class' => 'three column',
      Severity: Minor
      Found in includes/specials/SpecialTwnMainPage.php - About 1 hr to fix

        Function initLanguageSelector has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function initLanguageSelector() {
                    $form.find( '.signup-language-selector' ).uls( {
                        onSelect: function ( language ) {
                            var $checkbox = $form.find( 'input[name="signuplanguage"][value="' + language + '"]' );
                            if ( $checkbox.length ) {
        Severity: Minor
        Found in resources/js/ext.translate.mainpage.signup.js - About 1 hr to fix

          Function exports has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = function ( grunt ) {
              'use strict';
          
              grunt.loadNpmTasks( 'grunt-eslint' );
              grunt.loadNpmTasks( 'grunt-banana-checker' );
          Severity: Minor
          Found in Gruntfile.js - About 1 hr to fix

            Method getSandboxRows has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getSandboxRows() {
                    global $wgTranslateSandboxLimit;
            
                    $count = count( $this->translationStashReader->getTranslations( $this->getUser() ) );
            
            
            Severity: Minor
            Found in includes/specials/SpecialTwnMainPage.php - About 1 hr to fix

              Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function execute( $parameters ) {
                      $out = $this->getOutput();
                      $skin = $this->getSkin();
              
                      if ( !$this->getConfig()->get( 'TranslateUseSandbox' ) ) {
              Severity: Minor
              Found in includes/specials/SpecialTwnMainPage.php - About 1 hr to fix

                Function getCategoryFilter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function getCategoryFilter( array $args ): ?string {
                        foreach ( $args as $arg ) {
                            if ( trim( $arg ) === '' ) {
                                continue;
                            }
                Severity: Minor
                Found in src/Location/HookHandler.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        $tiles.on( 'click', function ( e ) {
                            e.stopPropagation();
                            location.href = $( this ).find( 'a' ).prop( 'href' );
                        } );
                Severity: Minor
                Found in resources/js/ext.translate.mainpage.js and 1 other location - About 45 mins to fix
                resources/js/ext.translate.mainpage.js on lines 135..139

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    $( '<span>' ).addClass( 'proofread' )
                                        .text( mw.msg( 'percent',
                                            mw.language.convertNumber( Math.round( proofread ) ) ) )
                Severity: Minor
                Found in resources/js/ext.translate.mainpage.js and 1 other location - About 45 mins to fix
                resources/js/ext.translate.mainpage.js on lines 77..79

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        $tiles.find( '.action' ).on( 'click', function ( e ) {
                            e.stopPropagation();
                
                            location.href = $( this ).find( 'a' ).prop( 'href' );
                        } );
                Severity: Minor
                Found in resources/js/ext.translate.mainpage.js and 1 other location - About 45 mins to fix
                resources/js/ext.translate.mainpage.js on lines 18..21

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    $( '<span>' ).addClass( 'translate' )
                                        .text( mw.msg( 'percent',
                                            mw.language.convertNumber( Math.round( translated ) ) ) ),
                Severity: Minor
                Found in resources/js/ext.translate.mainpage.js and 1 other location - About 45 mins to fix
                resources/js/ext.translate.mainpage.js on lines 80..82

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct( $key, $staleAge, $expiredAge, $worker, $onMiss = 'update' ) {
                Severity: Minor
                Found in includes/CachedStat.php - About 35 mins to fix

                  Function getStyles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getStyles( Context $context ) {
                          $out = '';
                          foreach ( $this->getData() as $key => $value ) {
                              if ( !isset( $value['raster'] ) ) {
                                  continue;
                  Severity: Minor
                  Found in includes/ResourceLoaderProjectIconsModule.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getProjects has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getProjects() {
                          $projects = [];
                  
                          $cache = ObjectCache::getInstance( CACHE_ANYTHING );
                          $cacheKey = $cache->makeKey( __METHOD__ );
                  Severity: Minor
                  Found in includes/ProjectHandler.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language