Sign upLogin

wikimedia/mediawiki-extensions-UniversalLanguageSelector

View on GitHub
Star
lib/jquery.webfonts/src/jquery.webfonts.js

Summary

Maintainability
D
1 day
Test Coverage

File jquery.webfonts.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * jQuery Webfonts.
 *
 * Copyright (C) 2012 Santhosh Thottingal
 *
Severity: Minor
Found in lib/jquery.webfonts/src/jquery.webfonts.js - About 3 hrs to fix

    Function parse has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            parse: function() {
            var webfonts = this,
                // Fonts can be added indirectly via classes, but also with
                // style attributes. For lang attributes we will use our font
                // if they don't have explicit font already.
    Severity: Major
    Found in lib/jquery.webfonts/src/jquery.webfonts.js - About 2 hrs to fix

      Function getCSS has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              getCSS: function( fontFamily, variant ) {
            var webfonts, base,
                fontFaceRule, userAgent, fontStyle, fontFormats, fullFontName,
                fontconfig = this.repository.get( fontFamily );
      Severity: Major
      Found in lib/jquery.webfonts/src/jquery.webfonts.js - About 2 hrs to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            $.fn.webfonts = function( option ) {
        return this.each( function() {
            var $this = $( this ),
                data = $this.data( 'webfonts' ),
                options = typeof option === 'object' && option;
        Severity: Major
        Found in lib/jquery.webfonts/src/jquery.webfonts.js and 3 other locations - About 4 hrs to fix
        lib/jquery.uls/src/jquery.uls.languagefilter.js on lines 347..361
        lib/jquery.uls/src/jquery.uls.lcd.js on lines 571..585
        resources/js/ext.uls.languagesettings.js on lines 301..315

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    for ( language in this.repository.languages ) {
                if ( this.repository.languages.hasOwnProperty( language ) ) {
                    languages.push( language );
                }
            }
        Severity: Minor
        Found in lib/jquery.webfonts/src/jquery.webfonts.js and 1 other location - About 50 mins to fix
        lib/jquery.webfonts/src/jquery.webfonts.js on lines 329..333

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        for ( fontName in this.repository.fonts ) {
                    if ( this.repository.fonts.hasOwnProperty( fontName ) ) {
                        fontNames.push( fontName );
                    }
                }
        Severity: Minor
        Found in lib/jquery.webfonts/src/jquery.webfonts.js and 1 other location - About 50 mins to fix
        lib/jquery.webfonts/src/jquery.webfonts.js on lines 348..352

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status