Sign upLogin

wikimedia/mediawiki-extensions-UniversalLanguageSelector

View on GitHub
Star
resources/js/ext.uls.interface.js

Summary

Maintainability
F
3 days
Test Coverage

File ext.uls.interface.js has 468 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * ULS interface integration logic
 *
 * Copyright (C) 2012-2013 Alolita Sharma, Amir Aharoni, Arun Ganesh, Brandon Harris,
 * Niklas Laxström, Pau Giner, Santhosh Thottingal, Siebrand Mazeland and other
Severity: Minor
Found in resources/js/ext.uls.interface.js - About 7 hrs to fix

    Function initPersonalEntryPoint has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function initPersonalEntryPoint() {
        var $trigger = $( '.uls-trigger' );
        var clickHandler;

        if ( !userCanChangeLanguage() ) {
    Severity: Major
    Found in resources/js/ext.uls.interface.js - About 2 hrs to fix

      Function showUndoTooltip has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function showUndoTooltip( previousLang, previousAutonym ) {
        var trigger, popup, popupPosition,
            configPosition = mw.config.get( 'wgULSPosition' ),
            triggerSelector = ( configPosition === 'interlanguage' ) ?
                '.uls-settings-trigger, .mw-interlanguage-selector' :
      Severity: Major
      Found in resources/js/ext.uls.interface.js - About 2 hrs to fix

        Function initInterlanguageEntryPoint has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function initInterlanguageEntryPoint() {
        var $pLang = $( '#p-lang' );

        var $trigger = $( '<button>' )
            .addClass( 'uls-settings-trigger' )
        Severity: Minor
        Found in resources/js/ext.uls.interface.js - About 1 hr to fix

          Function addEmptyState has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function addEmptyState( uls ) {
        var $emptyStateContainer = $( '<section>' ).addClass( 'uls-empty-state' );

        function openActionsMenuEventHandler( event ) {
            event.stopPropagation();
          Severity: Minor
          Found in resources/js/ext.uls.interface.js - About 1 hr to fix

            Function clickHandler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    var clickHandler = function ( e ) {
            var languagesettings = $trigger.data( 'languagesettings' ),
                languageSettingsOptions;

            if ( languagesettings ) {
            Severity: Minor
            Found in resources/js/ext.uls.interface.js - About 1 hr to fix

              Function addActionsMenuTriggers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function addActionsMenuTriggers( uls ) {
        var $ulsSettingsBlock = addLanguageSettingsTrigger( uls );

        var actionItemsRegistry = mw.uls.ActionsMenuItemsRegistry;
        actionItemsRegistry.on( 'register', onActionItemAdded );
              Severity: Minor
              Found in resources/js/ext.uls.interface.js - About 1 hr to fix

                Function loadContentLanguageSelector has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function loadContentLanguageSelector( ev ) {
        var $target = $( ev.currentTarget );

        // Avoid reinitializing ULS multiple times for an element
        if ( $target.attr( 'data-uls-loaded' ) ) {
                Severity: Minor
                Found in resources/js/ext.uls.interface.js - About 1 hr to fix

                  Function addLanguageSettingsToNonContentPages has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function addLanguageSettingsToNonContentPages() {
        var $languageBtn = $( '#p-lang-btn' );
        var clickHandler = function ( event ) {
            event.stopPropagation();
            mw.loader.using( languageSettingsModules ).then( function () {
                  Severity: Minor
                  Found in resources/js/ext.uls.interface.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                                    if ( offset.left + ( width / 2 ) > $( window ).width() / 2 ) {
                                    // Midpoint of the trigger is on the right side of the viewport.
                                    positionCSS = {
                                        // Right dialog edge aligns with right edge of the trigger.
                                        right: $( window ).width() - ( offset.left + width ),
                    Severity: Major
                    Found in resources/js/ext.uls.interface.js and 1 other location - About 4 hrs to fix
                    resources/js/ext.uls.launch.js on lines 86..100

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 129.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status