Sign upLogin

wikimedia/mediawiki-extensions-UploadWizard

View on GitHub
Star
includes/Hooks.php

Summary

Maintainability
C
1 day
Test Coverage

Method onGetPreferences has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function onGetPreferences( $user, &$preferences ) {
        $config = Config::getConfig();

        // User preference to skip the licensing tutorial, provided it's not globally disabled
        if ( Config::getSetting( 'tutorial' ) != [] ) {
Severity: Major
Found in includes/Hooks.php - About 3 hrs to fix

    Function onBeforePageDisplay has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function onBeforePageDisplay( $out, $skin ): void {
        $config = MediaWikiServices::getInstance()->getMainConfig();

        if ( ExtensionRegistry::getInstance()->isLoaded( 'WikibaseMediaInfo' ) ) {
            $properties = $config->get( 'MediaInfoProperties' );
    Severity: Minor
    Found in includes/Hooks.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onGetPreferences has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function onGetPreferences( $user, &$preferences ) {
        $config = Config::getConfig();

        // User preference to skip the licensing tutorial, provided it's not globally disabled
        if ( Config::getSetting( 'tutorial' ) != [] ) {
    Severity: Minor
    Found in includes/Hooks.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onBeforePageDisplay has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function onBeforePageDisplay( $out, $skin ): void {
        $config = MediaWikiServices::getInstance()->getMainConfig();

        if ( ExtensionRegistry::getInstance()->isLoaded( 'WikibaseMediaInfo' ) ) {
            $properties = $config->get( 'MediaInfoProperties' );
    Severity: Minor
    Found in includes/Hooks.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status