wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
editcheck/modules/EditCheckDialog.js

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

ve.ui.EditCheckDialog = function VeUiEditCheckDialog( config ) {
    // Parent constructor
    ve.ui.EditCheckDialog.super.call( this, config );

    // Pre-initialization
Severity: Major
Found in editcheck/modules/EditCheckDialog.js and 2 other locations - About 1 hr to fix
editcheck/modules/EditCheckInspector.js on lines 16..22
modules/ve-mw-collab/ve.ui.MWExportWikitextDialog.js on lines 17..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.EditCheckDialogTool = function VeUiEditCheckDialogTool() {
    ve.ui.EditCheckDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in editcheck/modules/EditCheckDialog.js and 12 other locations - About 40 mins to fix
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 37..39
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 66..68
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 95..97
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 124..126
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 153..155
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 182..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status