Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star

Showing 907 of 907 total issues

File ve.init.mw.ArticleTarget.js has 1478 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * VisualEditor MediaWiki Initialization ArticleTarget class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
Severity: Major
Found in modules/ve-mw/init/targets/ve.init.mw.ArticleTarget.js - About 3 days to fix

    File ve.ui.MWMediaDialog.js has 995 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * VisualEditor user interface MWMediaDialog class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
    Severity: Major
    Found in modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js - About 2 days to fix

      File ve.init.mw.DesktopArticleTarget.init.js has 959 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*!
 * VisualEditor MediaWiki DesktopArticleTarget init.
 *
 * This file must remain as widely compatible as the base compatibility
 * for MediaWiki itself (see mediawiki/core:/resources/startup.js).
      Severity: Major
      Found in modules/ve-mw/preinit/ve.init.mw.DesktopArticleTarget.init.js - About 2 days to fix

        File ve.init.mw.DesktopArticleTarget.js has 916 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*!
 * VisualEditor MediaWiki Initialization DesktopArticleTarget class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
        Severity: Major
        Found in modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js - About 2 days to fix

          File Hooks.php has 834 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
/**
 * VisualEditor extension hooks
 *
 * @file
          Severity: Major
          Found in includes/Hooks.php - About 2 days to fix

            File ve.ui.MWGalleryDialog.js has 822 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*!
 * VisualEditor user interface MWGalleryDialog class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
            Severity: Major
            Found in modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js - About 1 day to fix

              Function execute has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();
        $permissionManager = $this->getPermissionManager();
              Severity: Minor
              Found in includes/ApiVisualEditor.php - About 1 day to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File ve.dm.MWImageModel.js has 627 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              /*!
 * VisualEditor DataModel MWImageModel class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
              Severity: Major
              Found in modules/ve-mw/dm/models/ve.dm.MWImageModel.js - About 1 day to fix

                Method execute has 275 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();
        $permissionManager = $this->getPermissionManager();
                Severity: Major
                Found in includes/ApiVisualEditor.php - About 1 day to fix

                  File ve.ui.MWSaveDialog.js has 570 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  /*!
 * VisualEditor UserInterface MWSaveDialog class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
                  Severity: Major
                  Found in modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js - About 1 day to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    ve.ui.MWLanguageVariantOneWayInspector.prototype.initialize = function () {
    ve.ui.MWLanguageVariantOneWayInspector.super.prototype.initialize.call( this );
    this.items = [];
    this.layout = new OO.ui.FieldsetLayout( { } );
    this.form.$element.append( this.layout.$element );
                    Severity: Major
                    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js and 1 other location - About 1 day to fix
                    modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js on lines 558..572

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 223.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    ve.ui.MWLanguageVariantTwoWayInspector.prototype.initialize = function () {
    ve.ui.MWLanguageVariantTwoWayInspector.super.prototype.initialize.call( this );
    this.items = [];
    this.layout = new OO.ui.FieldsetLayout( { } );
    this.form.$element.append( this.layout.$element );
                    Severity: Major
                    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js and 1 other location - About 1 day to fix
                    modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js on lines 705..719

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 223.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function initialize has 228 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    ve.ui.MWGalleryDialog.prototype.initialize = function () {
    // Parent method
    ve.ui.MWGalleryDialog.super.prototype.initialize.call( this );

    // States
                    Severity: Major
                    Found in modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js - About 1 day to fix

                      File ve.ui.MWLanguageVariantInspector.js has 524 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /*!
 * VisualEditor UserInterface LanguageVariantInspector class.
 *
 * @copyright See AUTHORS.txt
 */
                      Severity: Major
                      Found in modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js - About 1 day to fix

                        Function initialize has 194 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        ve.ui.MWMediaDialog.prototype.initialize = function () {
    // Parent method
    ve.ui.MWMediaDialog.super.prototype.initialize.call( this );

    // Main layout
                        Severity: Major
                        Found in modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js - About 7 hrs to fix

                          Function buildMediaInfoPanel has 192 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          ve.ui.MWMediaDialog.prototype.buildMediaInfoPanel = function ( imageinfo ) {
    const contentDirection = this.getFragment().getDocument().getDir(),
        imageTitleText = imageinfo.title || imageinfo.canonicaltitle,
        imageTitle = new OO.ui.LabelWidget( {
            label: mw.Title.newFromText( imageTitleText ).getNameText()
                          Severity: Major
                          Found in modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js - About 7 hrs to fix

                            File ApiVisualEditorEdit.php has 469 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
/**
 * Parsoid/RESTBase+MediaWiki API wrapper.
 *
 * @file
                            Severity: Minor
                            Found in includes/ApiVisualEditorEdit.php - About 7 hrs to fix

                              File ApiVisualEditor.php has 462 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              <?php
/**
 * Parsoid/RESTBase+MediaWiki API wrapper.
 *
 * @file
                              Severity: Minor
                              Found in includes/ApiVisualEditor.php - About 7 hrs to fix

                                Function execute has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function execute() {
        $user = $this->getUser();
        $params = $this->extractRequestParams();

        $result = [];
                                Severity: Minor
                                Found in includes/ApiVisualEditorEdit.php - About 6 hrs to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Similar blocks of code found in 3 locations. Consider refactoring.
                                Open

                                    if ( this.tableOfContentsTouched ) {
        if ( newTableOfContentsData.data === 'default' ) {
            if ( currentTableOfContents ) {
                this.fragment.removeMeta( currentTableOfContents );
            }
                                Severity: Major
                                Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 2 other locations - About 6 hrs to fix
                                modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 256..273
                                modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 280..297

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 167.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language