Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js

Summary

Maintainability
D
2 days
Test Coverage

Function setTemplateData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

ve.dm.MWTemplateSpecModel.prototype.setTemplateData = function ( data ) {
    if ( !data || !ve.isPlainObject( data ) ) {
        return;
    }
Severity: Minor
Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setTemplateData has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.dm.MWTemplateSpecModel.prototype.setTemplateData = function ( data ) {
    if ( !data || !ve.isPlainObject( data ) ) {
        return;
    }
Severity: Minor
Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterExampleValue = function ( name, languageCode ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return this.constructor.static.getLocalValue( param && param.example || null, languageCode );
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 318..321

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterDescription = function ( name, languageCode ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return this.constructor.static.getLocalValue( param && param.description || null, languageCode );
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 349..352

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 93.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterAliases = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return param && param.aliases || [];
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 327..330

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterSuggestedValues = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return param && param.suggestedvalues || [];
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 381..384

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.isParameterRequired = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return !!( param && param.required );
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 411..414

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.isParameterSuggested = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return !!( param && param.suggested );
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 402..405

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterAutoValue = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return param && param.autovalue || '';
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 2 other locations - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 339..342
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 370..373

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterDefaultValue = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return param && param.default || '';
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 2 other locations - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 361..364
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 370..373

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getParameterType = function ( name ) {
    const param = this.templateData.params[ this.getPrimaryParameterName( name ) ];
    return param && param.type || 'string';
};
    Severity: Major
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 2 other locations - About 2 hrs to fix
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 339..342
    modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 361..364

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 75.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWTemplateSpecModel.prototype.getKnownParameterNames = function () {
    return Object.keys( this.seenParameterNames );
};
    Severity: Minor
    Found in modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js and 1 other location - About 35 mins to fix
    modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js on lines 289..291

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status