Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js

Summary

Maintainability
F
3 days
Test Coverage

Function toDomElements has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

ve.dm.MWBlockImageNode.static.toDomElements = function ( data, doc, converter ) {
    const dataElement = data[ 0 ],
        attributes = dataElement.attributes,
        figure = doc.createElement( 'figure' ),
        imgWrapper = doc.createElement( attributes.href ? 'a' : 'span' ),
Severity: Minor
Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toDataElement has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

ve.dm.MWBlockImageNode.static.toDataElement = function ( domElements, converter ) {
    const figure = domElements[ 0 ];
    const img = figure.querySelector( '.mw-file-element' ); // <img>, <video>, <audio>, or <span> if mw:Error
    // Images copied from the old parser output can have typeof=mw:Image but no resource information. T337438
    if ( !img || !img.hasAttribute( 'resource' ) ) {
Severity: Minor
Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function toDataElement has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.dm.MWBlockImageNode.static.toDataElement = function ( domElements, converter ) {
    const figure = domElements[ 0 ];
    const img = figure.querySelector( '.mw-file-element' ); // <img>, <video>, <audio>, or <span> if mw:Error
    // Images copied from the old parser output can have typeof=mw:Image but no resource information. T337438
    if ( !img || !img.hasAttribute( 'resource' ) ) {
Severity: Major
Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js - About 3 hrs to fix

    Function toDomElements has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.dm.MWBlockImageNode.static.toDomElements = function ( data, doc, converter ) {
    const dataElement = data[ 0 ],
        attributes = dataElement.attributes,
        figure = doc.createElement( 'figure' ),
        imgWrapper = doc.createElement( attributes.href ? 'a' : 'span' ),
    Severity: Major
    Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if ( attributes.isError ) {
        if ( converter.isForPreview() ) {
            imgWrapper.classList.add( 'new' );
        }
        const filename = mw.libs.ve.normalizeParsoidResourceName( attributes.resource || '' );
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 1 other location - About 3 hrs to fix
      modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js on lines 225..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      ve.dm.MWBlockImageNode = function VeDmMWBlockImageNode() {
    // Parent constructor
    ve.dm.MWBlockImageNode.super.apply( this, arguments );

    // Mixin constructors
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 2 other locations - About 3 hrs to fix
      modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js on lines 19..26
      modules/ve-mw/dm/nodes/ve.dm.MWSignatureNode.js on lines 19..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if ( captionNode ) {
        caption = converter.getDataFromDomClean( captionNode, { type: 'mwImageCaption' } );
    } else {
        caption = [
            { type: 'mwImageCaption' },
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 1 other location - About 2 hrs to fix
      modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 114..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          if ( href ) {
        // Convert absolute URLs to relative if the href refers to a page on this wiki.
        // Otherwise Parsoid generates |link= options for copy-pasted images (T193253).
        const targetData = mw.libs.ve.getTargetDataFromHref( href, converter.getTargetHtmlDocument() );
        if ( targetData.isInternal ) {
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 2 other locations - About 2 hrs to fix
      modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 139..146
      modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js on lines 74..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ve.dm.MWBlockImageNode.static.preserveHtmlAttributes = function ( attribute ) {
    const attributes = [ 'typeof', 'class', 'src', 'resource', 'width', 'height', 'href', 'rel', 'data-mw', 'alt' ];
    return attributes.indexOf( attribute ) === -1;
};
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 1 other location - About 1 hr to fix
      modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 43..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ve.dm.MWBlockImageNode.prototype.getCaptionNode = function () {
    const node = this.children[ 0 ];
    return node instanceof ve.dm.MWImageCaptionNode ? node : null;
};
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 1 other location - About 1 hr to fix
      modules/ve-mw/dm/nodes/ve.dm.MWGalleryNode.js on lines 114..117

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if ( !ve.isEmptyObject( attributes.mw ) ) {
        figure.setAttribute( 'data-mw', JSON.stringify( attributes.mw ) );
    }
      Severity: Minor
      Found in modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js and 1 other location - About 30 mins to fix
      modules/ve-mw/dm/nodes/ve.dm.MWInlineImageNode.js on lines 179..181

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status