Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js

Summary

Maintainability
C
1 day
Test Coverage

Function describeChanges has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.dm.MWExtensionNode.static.describeChanges = function ( attributeChanges, attributes, element ) {
    const descriptions = [],
        fromBody = attributeChanges.mw.from.body,
        toBody = attributeChanges.mw.to.body;
Severity: Minor
Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js - About 1 hr to fix

    Function describeChanges has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    ve.dm.MWExtensionNode.static.describeChanges = function ( attributeChanges, attributes, element ) {
    const descriptions = [],
        fromBody = attributeChanges.mw.from.body,
        toBody = attributeChanges.mw.to.body;
    Severity: Minor
    Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function toDomElements has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    ve.dm.MWExtensionNode.static.toDomElements = function ( dataElement, doc, converter ) {
    const originalMw = dataElement.attributes.originalMw;

    let els;
    // If the transclusion is unchanged just send back the
    Severity: Minor
    Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    ve.dm.MWExtensionNode = function VeDmMWExtensionNode() {
    // Parent constructor
    ve.dm.MWExtensionNode.super.apply( this, arguments );

    // Mixin constructors
    Severity: Major
    Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js and 2 other locations - About 3 hrs to fix
    modules/ve-mw/dm/nodes/ve.dm.MWBlockImageNode.js on lines 20..27
    modules/ve-mw/dm/nodes/ve.dm.MWSignatureNode.js on lines 19..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.dm.MWExtensionNode.static.getHashObject = function ( dataElement ) {
    return {
        type: dataElement.type,
        mw: ve.copy( dataElement.attributes.mw )
    };
    Severity: Major
    Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js and 1 other location - About 1 hr to fix
    modules/ve-mw/dm/nodes/ve.dm.MWGalleryNode.js on lines 51..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                ve.ui.DiffElement.static.compareAttributes( attributeChanges.mw.from.attrs || {}, attributeChanges.mw.to.attrs || {} ),
    Severity: Major
    Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js and 1 other location - About 1 hr to fix
    modules/ve-mw/dm/nodes/ve.dm.MWGalleryNode.js on lines 86..86

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (
            converter.doesModeNeedRendering() &&
            // Use getHashObjectForRendering to get the rendering from the store
            ( value = store.value( store.hashOfValue( null, OO.getHash( [ this.getHashObjectForRendering( dataElement ), undefined ] ) ) ) )
        ) {
    Severity: Major
    Found in modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js and 1 other location - About 1 hr to fix
    modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js on lines 163..178

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status