Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/dm/nodes/ve.dm.MWGalleryCaptionNode.js

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.dm.MWGalleryCaptionNode.static.matchFunction = function ( element ) {
    const parentTypeof = ( element.parentNode && element.parentNode.getAttribute( 'typeof' ) ) || '';
    return element.getAttribute( 'class' ) === 'gallerycaption' &&
        parentTypeof.trim().split( /\s+/ ).indexOf( 'mw:Extension/gallery' ) !== -1;
};
Severity: Major
Found in modules/ve-mw/dm/nodes/ve.dm.MWGalleryCaptionNode.js and 1 other location - About 3 hrs to fix
modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 35..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

ve.dm.MWGalleryCaptionNode.static.toDomElements = function ( dataElement, doc ) {
    const li = doc.createElement( 'li' );
    li.classList.add( 'gallerycaption' );
    return [ li ];
};
Severity: Major
Found in modules/ve-mw/dm/nodes/ve.dm.MWGalleryCaptionNode.js and 1 other location - About 1 hr to fix
modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageCaptionNode.js on lines 31..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

ve.dm.MWGalleryCaptionNode = function VeDmMWGalleryCaptionNode() {
    // Parent constructor
    ve.dm.MWGalleryCaptionNode.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/dm/nodes/ve.dm.MWGalleryCaptionNode.js and 10 other locations - About 50 mins to fix
modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageCaptionNode.js on lines 18..21
modules/ve-mw/dm/nodes/ve.dm.MWImageCaptionNode.js on lines 18..21
modules/ve-mw/dm/nodes/ve.dm.MWLanguageVariantBlockNode.js on lines 18..21
modules/ve-mw/dm/nodes/ve.dm.MWLanguageVariantHiddenNode.js on lines 18..21
modules/ve-mw/dm/nodes/ve.dm.MWLanguageVariantInlineNode.js on lines 18..21
modules/ve-mw/dm/nodes/ve.dm.MWTransclusionBlockNode.js on lines 17..20
modules/ve-mw/dm/nodes/ve.dm.MWTransclusionInlineNode.js on lines 17..20
modules/ve-mw/ui/actions/ve.ui.MWSaveDialogAction.js on lines 81..84
modules/ve-mw/ui/tools/ve.ui.MWBackTool.js on lines 11..14
modules/ve-mw/ui/tools/ve.ui.MWSignatureTool.js on lines 17..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status