Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js

Summary

Maintainability
D
2 days
Test Coverage

Function describeChanges has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

ve.dm.MWImageNode.static.describeChanges = function ( attributeChanges, attributes ) {
    const customKeys = [ 'width', 'height', 'defaultSize', 'src', 'href' ],
        descriptions = [];

    function describeSize( width, height ) {
Severity: Minor
Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function syncScalableToType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

ve.dm.MWImageNode.static.syncScalableToType = function ( type, mediaType, scalable ) {
    const defaultThumbSize = mw.config.get( 'wgVisualEditorConfig' )
        .thumbLimits[ mw.user.options.get( 'thumbsize' ) ];

    const originalDimensions = scalable.getOriginalDimensions();
Severity: Minor
Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function describeChanges has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.dm.MWImageNode.static.describeChanges = function ( attributeChanges, attributes ) {
    const customKeys = [ 'width', 'height', 'defaultSize', 'src', 'href' ],
        descriptions = [];

    function describeSize( width, height ) {
Severity: Minor
Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js - About 1 hr to fix

    Function syncScalableToType has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.dm.MWImageNode.static.syncScalableToType = function ( type, mediaType, scalable ) {
    const defaultThumbSize = mw.config.get( 'wgVisualEditorConfig' )
        .thumbLimits[ mw.user.options.get( 'thumbsize' ) ];

    const originalDimensions = scalable.getOriginalDimensions();
    Severity: Minor
    Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js - About 1 hr to fix

      Function scaleToThumbnailSize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      ve.dm.MWImageNode.static.scaleToThumbnailSize = function ( dimensions, mediaType ) {
    const defaultThumbSize = mw.config.get( 'wgVisualEditorConfig' )
        .thumbLimits[ mw.user.options.get( 'thumbsize' ) ];

    mediaType = mediaType || 'BITMAP';
      Severity: Minor
      Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( attributeChanges.defaultSize && attributeChanges.defaultSize.to === true ) {
            sizeTo = ve.msg( 'visualeditor-mediasizewidget-sizeoptions-default' );
        } else {
            sizeTo = describeSize(
                'width' in attributeChanges ? attributeChanges.width.to : attributes.width,
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js and 1 other location - About 3 hrs to fix
      modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js on lines 135..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( attributeChanges.defaultSize && attributeChanges.defaultSize.from === true ) {
            sizeFrom = ve.msg( 'visualeditor-mediasizewidget-sizeoptions-default' );
        } else {
            sizeFrom = describeSize(
                'width' in attributeChanges ? attributeChanges.width.from : attributes.width,
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js and 1 other location - About 3 hrs to fix
      modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js on lines 143..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      ve.dm.MWImageNode.static.isDiffComparable = function ( element, other ) {
    // Images with different src's shouldn't be diffed
    return element.type === other.type && element.attributes.resource === other.attributes.resource;
};
      Severity: Major
      Found in modules/ve-mw/dm/nodes/ve.dm.MWImageNode.js and 1 other location - About 1 hr to fix
      modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 274..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status