Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/preinit/ve.utils.parsoid.js

Summary

Maintainability
C
1 day
Test Coverage

Function getTargetDataFromHref has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

mw.libs.ve.getTargetDataFromHref = function ( href, doc ) {
    function regexEscape( str ) {
        return str.replace( /([.?*+^$[\]\\(){}|-])/g, '\\$1' );
    }
Severity: Minor
Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 1 hr to fix

    Function fixFragmentLinks has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    mw.libs.ve.fixFragmentLinks = function ( container, docTitle, prefix ) {
    const docTitleText = docTitle.getPrefixedText();
    prefix = prefix || '';
    Array.prototype.forEach.call( container.querySelectorAll( 'a[href*="#"]' ), ( el ) => {
        let fragment = null;
    Severity: Minor
    Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 1 hr to fix

      Function reduplicateStyles has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      mw.libs.ve.reduplicateStyles = function ( element ) {
    Array.prototype.forEach.call( element.querySelectorAll( 'link[rel~="mw-deduplicated-inline-style"]' ), ( link ) => {
        const href = link.getAttribute( 'href' );
        if ( !href || href.slice( 0, 'mw-data:'.length ) !== 'mw-data:' ) {
            return;
      Severity: Minor
      Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 1 hr to fix

        Function getTargetDataFromHref has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        mw.libs.ve.getTargetDataFromHref = function ( href, doc ) {
    function regexEscape( str ) {
        return str.replace( /([.?*+^$[\]\\(){}|-])/g, '\\$1' );
    }
        Severity: Minor
        Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function unwrapParsoidSections has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        mw.libs.ve.unwrapParsoidSections = function ( element, keepSection ) {
    Array.prototype.forEach.call( element.querySelectorAll( 'section[data-mw-section-id]' ), ( section ) => {
        const parent = section.parentNode,
            sectionId = section.getAttribute( 'data-mw-section-id' );
        // Copy section ID to first child (should be a heading)
        Severity: Minor
        Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function reduplicateStyles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        mw.libs.ve.reduplicateStyles = function ( element ) {
    Array.prototype.forEach.call( element.querySelectorAll( 'link[rel~="mw-deduplicated-inline-style"]' ), ( link ) => {
        const href = link.getAttribute( 'href' );
        if ( !href || href.slice( 0, 'mw-data:'.length ) !== 'mw-data:' ) {
            return;
        Severity: Minor
        Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return returnExternalData();
        Severity: Major
        Found in modules/ve-mw/preinit/ve.utils.parsoid.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      Array.prototype.forEach.call( style.attributes, ( attr ) => {
                if ( attr.name !== 'rel' && attr.name !== 'data-mw-deduplicate' ) {
                    link.setAttribute( attr.name, attr.value );
                }
            } );
          Severity: Major
          Found in modules/ve-mw/preinit/ve.utils.parsoid.js and 1 other location - About 2 hrs to fix
          modules/ve-mw/preinit/ve.utils.parsoid.js on lines 110..114

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 79.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  Array.prototype.forEach.call( link.attributes, ( attr ) => {
            if ( attr.name !== 'rel' && attr.name !== 'href' ) {
                newStyle.setAttribute( attr.name, attr.value );
            }
        } );
          Severity: Major
          Found in modules/ve-mw/preinit/ve.utils.parsoid.js and 1 other location - About 2 hrs to fix
          modules/ve-mw/preinit/ve.utils.parsoid.js on lines 171..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 79.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const scriptBase = new URL( mw.config.get( 'wgScript' ), doc.baseURI ).toString().replace( /^https?:/i, '' );
          Severity: Minor
          Found in modules/ve-mw/preinit/ve.utils.parsoid.js and 1 other location - About 35 mins to fix
          modules/ve-mw/preinit/ve.utils.parsoid.js on lines 317..317

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const articleBase = new URL( mw.config.get( 'wgArticlePath' ), doc.baseURI ).toString().replace( /^https?:/i, '' );
          Severity: Minor
          Found in modules/ve-mw/preinit/ve.utils.parsoid.js and 1 other location - About 35 mins to fix
          modules/ve-mw/preinit/ve.utils.parsoid.js on lines 309..309

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status