Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function wrapLine has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

ve.ui.MWWikitextAction.prototype.wrapLine = function ( before, after, placeholder, unwrapOffsetsCallback ) {
    let originalFragment = this.surface.getModel().getFragment( null, false, true /* excludeInsertions */ );
    const selectedNodes = originalFragment.getLeafNodes();

    let unwrapped = false;
Severity: Minor
Found in modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function wrapLine has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.ui.MWWikitextAction.prototype.wrapLine = function ( before, after, placeholder, unwrapOffsetsCallback ) {
    let originalFragment = this.surface.getModel().getFragment( null, false, true /* excludeInsertions */ );
    const selectedNodes = originalFragment.getLeafNodes();

    let unwrapped = false;
Severity: Minor
Found in modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js - About 1 hr to fix

    Function toggleWrapSelection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWWikitextAction.prototype.toggleWrapSelection = function ( before, after, placeholder, expandOffsetsCallback, unwrapOffsetsCallback ) {
    const originalFragment = this.surface.getModel().getFragment( null, false, true /* excludeInsertions */ );

    let fragment = originalFragment;
    let textBefore, textAfter;
    Severity: Minor
    Found in modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js - About 1 hr to fix

      Function toggleWrapSelection has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      ve.ui.MWWikitextAction.prototype.toggleWrapSelection = function ( before, after, placeholder, expandOffsetsCallback, unwrapOffsetsCallback ) {
      Severity: Minor
      Found in modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js - About 35 mins to fix

        Function toggleWrapSelection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        ve.ui.MWWikitextAction.prototype.toggleWrapSelection = function ( before, after, placeholder, expandOffsetsCallback, unwrapOffsetsCallback ) {
    const originalFragment = this.surface.getModel().getFragment( null, false, true /* excludeInsertions */ );

    let fragment = originalFragment;
    let textBefore, textAfter;
        Severity: Minor
        Found in modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 50 locations. Consider refactoring.
        Open

        ve.ui.MWWikitextAction = function VeUiMWWikitextAction() {
    // Parent constructor
    ve.ui.MWWikitextAction.super.apply( this, arguments );
};
        Severity: Major
        Found in modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js and 49 other locations - About 55 mins to fix
        modules/ve-mw/ce/nodes/ve.ce.MWAlienAnnotationNode.js on lines 19..22
        modules/ve-mw/ce/nodes/ve.ce.MWBlockExtensionNode.js on lines 19..22
        modules/ve-mw/ce/nodes/ve.ce.MWInlineExtensionNode.js on lines 19..22
        modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantBlockNode.js on lines 18..21
        modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantHiddenNode.js on lines 18..21
        modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantInlineNode.js on lines 19..22
        modules/ve-mw/ce/nodes/ve.ce.MWPreNode.js on lines 18..21
        modules/ve-mw/ce/nodes/ve.ce.MWPreformattedNode.js on lines 17..20
        modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js on lines 25..28
        modules/ve-mw/dm/annotations/ve.dm.MWInternalLinkAnnotation.js on lines 20..23
        modules/ve-mw/dm/annotations/ve.dm.MWNowikiAnnotation.js on lines 19..22
        modules/ve-mw/dm/metaitems/ve.dm.MWAlienMetaItem.js on lines 17..20
        modules/ve-mw/dm/metaitems/ve.dm.MWCategoryMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWDefaultSortMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWDisplayTitleMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js on lines 17..20
        modules/ve-mw/dm/metaitems/ve.dm.MWHiddenCategoryMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWIndexMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWLanguageMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWNewSectionEditMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWNoContentConvertMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWNoEditSectionMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWNoGalleryMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWNoTitleConvertMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWStaticRedirectMetaItem.js on lines 16..19
        modules/ve-mw/dm/metaitems/ve.dm.MWTOCMetaItem.js on lines 16..19
        modules/ve-mw/dm/models/ve.dm.MWTemplatePlaceholderModel.js on lines 18..21
        modules/ve-mw/dm/nodes/ve.dm.MWAlienAnnotationNode.js on lines 19..22
        modules/ve-mw/dm/nodes/ve.dm.MWAnnotationNode.js on lines 16..19
        modules/ve-mw/dm/nodes/ve.dm.MWBlockExtensionNode.js on lines 19..22
        modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js on lines 17..20
        modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 18..21
        modules/ve-mw/dm/nodes/ve.dm.MWHeadingNode.js on lines 18..21
        modules/ve-mw/dm/nodes/ve.dm.MWIncludesNode.js on lines 16..19
        modules/ve-mw/dm/nodes/ve.dm.MWInlineExtensionNode.js on lines 18..21
        modules/ve-mw/dm/nodes/ve.dm.MWPreNode.js on lines 17..20
        modules/ve-mw/dm/nodes/ve.dm.MWPreformattedNode.js on lines 18..21
        modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js on lines 16..19
        modules/ve-mw/ui/contextitems/ve.ui.MWAlienAnnotationContextItem.js on lines 18..21
        modules/ve-mw/ui/datatransferhandlers/ve.ui.MWMediaTransferHandler.js on lines 17..20
        modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextPlainTextStringTransferHandler.js on lines 26..29
        modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js on lines 17..20
        modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js on lines 16..19
        modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js on lines 17..20
        modules/ve-mw/ui/inspectors/ve.ui.MWMagicLinkNodeInspector.js on lines 17..20
        modules/ve-mw/ui/widgets/ve.ui.MWExternalLinkAnnotationWidget.js on lines 17..20
        modules/ve-mw/ui/widgets/ve.ui.MWInternalLinkAnnotationWidget.js on lines 17..20
        modules/ve-mw/ui/widgets/ve.ui.MWParameterCheckboxInputWidget.js on lines 16..19

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status