Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js

Summary

Maintainability
D
1 day
Test Coverage

File ve.ui.MWLinkAnnotationInspector.js has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * VisualEditor UserInterface LinkAnnotationInspector class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
Severity: Minor
Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js - About 3 hrs to fix

    Function initialize has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWLinkAnnotationInspector.prototype.initialize = function () {
    // Properties
    this.allowProtocolInInternal = false;
    this.internalAnnotationInput = this.createInternalAnnotationInput();
    this.externalAnnotationInput = this.createExternalAnnotationInput();
    Severity: Major
    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js - About 2 hrs to fix

      Function getTeardownProcess has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ve.ui.MWLinkAnnotationInspector.prototype.getTeardownProcess = function ( data ) {
    let fragment;
    return ve.ui.MWLinkAnnotationInspector.super.prototype.getTeardownProcess.call( this, data )
        .first( () => {
            // Save the original fragment for later.
      Severity: Minor
      Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ( this.isActive && !this.trackedInternalLinkInputChange && !this.switchingLinkTypes ) {
        ve.track( 'activity.' + this.constructor.static.name, { action: 'search-pages-input' } );
        this.trackedInternalLinkInputChange = true;
    }
        Severity: Major
        Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js and 1 other location - About 2 hrs to fix
        modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js on lines 327..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if ( this.isActive && !this.trackedExternalLinkInputChange && !this.switchingLinkTypes ) {
        ve.track( 'activity.' + this.constructor.static.name, { action: 'external-link-input' } );
        this.trackedExternalLinkInputChange = true;
    }
        Severity: Major
        Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js and 1 other location - About 2 hrs to fix
        modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js on lines 274..277

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        ve.ui.MWLinkAnnotationInspector.prototype.onInternalLinkSearchResultsChoose = function () {
    ve.track( 'activity.' + this.constructor.static.name, { action: 'search-pages-choose' } );
};
        Severity: Major
        Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js and 1 other location - About 1 hr to fix
        modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js on lines 857..861

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            this.externalAnnotationField = new OO.ui.FieldLayout(
        this.externalAnnotationInput,
        {
            align: 'top',
            label: ve.msg( 'visualeditor-linkinspector-title' )
        Severity: Minor
        Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js and 1 other location - About 35 mins to fix
        modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js on lines 37..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        ve.ui.MWLinkAnnotationInspector.prototype.createExternalAnnotationInput = function () {
    return new ve.ui.MWExternalLinkAnnotationWidget();
};
        Severity: Minor
        Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js and 1 other location - About 35 mins to fix
        modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js on lines 136..138

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        ve.ui.MWLinkAnnotationInspector.prototype.createInternalAnnotationInput = function () {
    return new ve.ui.MWInternalLinkAnnotationWidget();
};
        Severity: Minor
        Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js and 1 other location - About 35 mins to fix
        modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js on lines 143..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status