Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js

Summary

Maintainability
C
1 day
Test Coverage

Function getTeardownProcess has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.ui.MWLinkNodeInspector.prototype.getTeardownProcess = function ( data ) {
    data = data || {};
    return ve.ui.MWLinkNodeInspector.super.prototype.getTeardownProcess.call( this, data )
        .first( () => {
            let value = this.targetInput.getValue();
Severity: Minor
Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    ve.ui.MWLinkNodeInspector.prototype.getReadyProcess = function ( data ) {
    return ve.ui.MWLinkNodeInspector.super.prototype.getReadyProcess.call( this, data )
        .next( () => {
            this.targetInput.focus().select();
        } );
    Severity: Major
    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js and 1 other location - About 3 hrs to fix
    modules/ve-mw/ui/inspectors/ve.ui.MWMagicLinkNodeInspector.js on lines 135..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    ve.ui.MWLinkNodeInspector.static.actions = [
    ...ve.ui.MWLinkNodeInspector.super.static.actions,
    {
        action: 'convert',
        label: OO.ui.deferMsg( 'visualeditor-linknodeinspector-add-label' ),
    Severity: Major
    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js and 2 other locations - About 2 hrs to fix
    modules/ve-mw/ui/dialogs/ve.ui.MWPreDialog.js on lines 38..45
    modules/ve-mw/ui/inspectors/ve.ui.MWMagicLinkNodeInspector.js on lines 34..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 50 locations. Consider refactoring.
    Open

    ve.ui.MWLinkNodeInspector = function VeUiMWLinkNodeInspector() {
    // Parent constructor
    ve.ui.MWLinkNodeInspector.super.apply( this, arguments );
};
    Severity: Major
    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js and 49 other locations - About 55 mins to fix
    modules/ve-mw/ce/nodes/ve.ce.MWAlienAnnotationNode.js on lines 19..22
    modules/ve-mw/ce/nodes/ve.ce.MWBlockExtensionNode.js on lines 19..22
    modules/ve-mw/ce/nodes/ve.ce.MWInlineExtensionNode.js on lines 19..22
    modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantBlockNode.js on lines 18..21
    modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantHiddenNode.js on lines 18..21
    modules/ve-mw/ce/nodes/ve.ce.MWLanguageVariantInlineNode.js on lines 19..22
    modules/ve-mw/ce/nodes/ve.ce.MWPreNode.js on lines 18..21
    modules/ve-mw/ce/nodes/ve.ce.MWPreformattedNode.js on lines 17..20
    modules/ve-mw/dm/annotations/ve.dm.MWExternalLinkAnnotation.js on lines 25..28
    modules/ve-mw/dm/annotations/ve.dm.MWInternalLinkAnnotation.js on lines 20..23
    modules/ve-mw/dm/annotations/ve.dm.MWNowikiAnnotation.js on lines 19..22
    modules/ve-mw/dm/metaitems/ve.dm.MWAlienMetaItem.js on lines 17..20
    modules/ve-mw/dm/metaitems/ve.dm.MWCategoryMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWDefaultSortMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWDisplayTitleMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWFlaggedMetaItem.js on lines 17..20
    modules/ve-mw/dm/metaitems/ve.dm.MWHiddenCategoryMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWIndexMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWLanguageMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWNewSectionEditMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWNoContentConvertMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWNoEditSectionMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWNoGalleryMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWNoTitleConvertMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWRedirectMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWStaticRedirectMetaItem.js on lines 16..19
    modules/ve-mw/dm/metaitems/ve.dm.MWTOCMetaItem.js on lines 16..19
    modules/ve-mw/dm/models/ve.dm.MWTemplatePlaceholderModel.js on lines 18..21
    modules/ve-mw/dm/nodes/ve.dm.MWAlienAnnotationNode.js on lines 19..22
    modules/ve-mw/dm/nodes/ve.dm.MWAnnotationNode.js on lines 16..19
    modules/ve-mw/dm/nodes/ve.dm.MWBlockExtensionNode.js on lines 19..22
    modules/ve-mw/dm/nodes/ve.dm.MWEntityNode.js on lines 17..20
    modules/ve-mw/dm/nodes/ve.dm.MWGalleryImageNode.js on lines 18..21
    modules/ve-mw/dm/nodes/ve.dm.MWHeadingNode.js on lines 18..21
    modules/ve-mw/dm/nodes/ve.dm.MWIncludesNode.js on lines 16..19
    modules/ve-mw/dm/nodes/ve.dm.MWInlineExtensionNode.js on lines 18..21
    modules/ve-mw/dm/nodes/ve.dm.MWPreNode.js on lines 17..20
    modules/ve-mw/dm/nodes/ve.dm.MWPreformattedNode.js on lines 18..21
    modules/ve-mw/dm/ve.dm.MWWikitextSurfaceFragment.js on lines 16..19
    modules/ve-mw/ui/actions/ve.ui.MWWikitextAction.js on lines 16..19
    modules/ve-mw/ui/contextitems/ve.ui.MWAlienAnnotationContextItem.js on lines 18..21
    modules/ve-mw/ui/datatransferhandlers/ve.ui.MWMediaTransferHandler.js on lines 17..20
    modules/ve-mw/ui/datatransferhandlers/ve.ui.MWWikitextPlainTextStringTransferHandler.js on lines 26..29
    modules/ve-mw/ui/inspectors/ve.ui.MWCommentInspector.js on lines 17..20
    modules/ve-mw/ui/inspectors/ve.ui.MWLanguageVariantInspector.js on lines 16..19
    modules/ve-mw/ui/inspectors/ve.ui.MWMagicLinkNodeInspector.js on lines 17..20
    modules/ve-mw/ui/widgets/ve.ui.MWExternalLinkAnnotationWidget.js on lines 17..20
    modules/ve-mw/ui/widgets/ve.ui.MWInternalLinkAnnotationWidget.js on lines 17..20
    modules/ve-mw/ui/widgets/ve.ui.MWParameterCheckboxInputWidget.js on lines 16..19

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if ( action === 'convert' ) {
        return new OO.ui.Process( () => {
            this.close( { action: action } );
        } );
    }
    Severity: Minor
    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js and 1 other location - About 40 mins to fix
    modules/ve-mw/ui/inspectors/ve.ui.MWMagicLinkNodeInspector.js on lines 94..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                } else {
                surfaceModel.change(
                    ve.dm.TransactionBuilder.static.newFromAttributeChanges(
                        doc, nodeRange.start, { href: value }
                    )
    Severity: Minor
    Found in modules/ve-mw/ui/inspectors/ve.ui.MWLinkNodeInspector.js and 1 other location - About 35 mins to fix
    modules/ve-mw/ui/inspectors/ve.ui.MWMagicLinkNodeInspector.js on lines 178..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status