Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js

Summary

Maintainability
F
5 days
Test Coverage

Function teardown has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

ve.ui.MWSettingsPage.prototype.teardown = function ( data ) {
    // Data initialisation
    data = data || {};
    if ( data.action !== 'done' ) {
        return;
Severity: Minor
Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function VeUiMWSettingsPage has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.ui.MWSettingsPage = function VeUiMWSettingsPage( name, config ) {
    // Parent constructor
    ve.ui.MWSettingsPage.super.apply( this, arguments );

    // Properties
Severity: Major
Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 4 hrs to fix

    Function teardown has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWSettingsPage.prototype.teardown = function ( data ) {
    // Data initialisation
    data = data || {};
    if ( data.action !== 'done' ) {
        return;
    Severity: Major
    Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 2 hrs to fix

      File ve.ui.MWSettingsPage.js has 268 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*!
 * VisualEditor user interface MWSettingsPage class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
      Severity: Minor
      Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 2 hrs to fix

        Function setup has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ve.ui.MWSettingsPage.prototype.setup = function ( fragment, config ) {
    this.fragment = fragment;

    // Table of Contents items
    const tableOfContentsField = this.tableOfContents.getField();
        Severity: Minor
        Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              if ( this.tableOfContentsTouched ) {
        if ( newTableOfContentsData.data === 'default' ) {
            if ( currentTableOfContents ) {
                this.fragment.removeMeta( currentTableOfContents );
            }
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 2 other locations - About 6 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 256..273
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 280..297

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 167.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              this.metaItemCheckboxes.forEach( ( metaItemCheckbox ) => {
        const currentItem = this.getMetaItem( metaItemCheckbox.metaName ),
            isSelected = metaItemCheckbox.fieldLayout.getField().isSelected();

        if ( currentItem && !isSelected ) {
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 4 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 334..343

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if ( currentRedirectTargetItem ) {
            if ( newRedirectData ) {
                if ( currentRedirectTargetItem.getAttribute( 'title' ) !== newRedirectData ) {
                    // There was a redirect and is a new one, but they differ, so replace
                    this.fragment.replaceMeta(
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 4 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 309..331

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 121.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if ( mw.config.get( 'wgNamespaceNumber' ) === mw.config.get( 'wgNamespaceIds' ).category ) {
        this.metaItemCheckboxes.push(
            {
                metaName: 'mwHiddenCategory',
                label: ve.msg( 'visualeditor-dialog-meta-settings-hiddencat-label' ),
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 2 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 104..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              this.metaItemCheckboxes.forEach( ( metaItemCheckbox ) => {
        const isSelected = !!this.getMetaItem( metaItemCheckbox.metaName );
        metaItemCheckbox.fieldLayout.getField()
            .setSelected( isSelected )
            .setDisabled( config.isReadOnly );
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 2 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 229..234

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.enableRedirectField = new OO.ui.FieldLayout(
        this.enableRedirectInput,
        {
            $overlay: config.$overlay,
            classes: [ 've-test-page-settings-enable-redirect' ],
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 2 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js on lines 89..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.enableStaticRedirectField = new OO.ui.FieldLayout(
        this.enableStaticRedirectInput,
        {
            $overlay: config.$overlay,
            classes: [ 've-test-page-settings-prevent-redirect' ],
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 2 hrs to fix
          modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js on lines 67..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 76.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          ve.ui.MWSettingsPage.prototype.getMetaItem = function ( name ) {
    return this.fragment.getDocument().getMetaList().getItemsInGroup( name )[ 0 ] || null;
};
          Severity: Major
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 1 hr to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 174..176

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.settingsFieldset = new OO.ui.FieldsetLayout( {
        label: ve.msg( 'visualeditor-dialog-meta-settings-label' ),
        icon: 'pageSettings'
    } );
          Severity: Minor
          Found in modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js and 1 other location - About 30 mins to fix
          modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js on lines 28..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status