Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ve.ui.commandRegistry.register(
    new ve.ui.Command(
        'meta/advanced', 'window', 'open',
        { args: [ 'meta', { page: 'advancedSettings' } ] }
    )
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 3 other locations - About 50 mins to fix
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 79..84
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 108..113
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 166..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ve.ui.commandRegistry.register(
    new ve.ui.Command(
        'meta/categories', 'window', 'open',
        { args: [ 'meta', { page: 'categories' } ] }
    )
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 3 other locations - About 50 mins to fix
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 108..113
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 137..142
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 166..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ve.ui.commandRegistry.register(
    new ve.ui.Command(
        'meta/settings', 'window', 'open',
        { args: [ 'meta', { page: 'settings' } ] }
    )
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 3 other locations - About 50 mins to fix
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 79..84
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 137..142
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 166..171

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

ve.ui.commandRegistry.register(
    new ve.ui.Command(
        'meta/languages', 'window', 'open',
        { args: [ 'meta', { page: 'languages' } ] }
    )
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 3 other locations - About 50 mins to fix
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 79..84
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 108..113
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 137..142

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

ve.ui.MWVeOnlyDialogTool = function VeUiMWVeOnlyDialogTool() {
    ve.ui.MWVeOnlyDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 4 other locations - About 40 mins to fix
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 17..19
modules/ve-mw/ui/tools/ve.ui.MWGalleryDialogTool.js on lines 17..19
modules/ve-mw/ui/tools/ve.ui.MWMediaDialogTool.js on lines 17..19
modules/ve-mw/ui/tools/ve.ui.MWMobileLinkInspectorTool.js on lines 18..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.MWCategoriesDialogTool = function VeUiMWCategoriesDialogTool() {
    ve.ui.MWCategoriesDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 12 other locations - About 40 mins to fix
editcheck/modules/EditCheckDialog.js on lines 117..119
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 37..39
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 95..97
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 124..126
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 153..155
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 182..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.MWPageSettingsDialogTool = function VeUiMWPageSettingsDialogTool() {
    ve.ui.MWPageSettingsDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 12 other locations - About 40 mins to fix
editcheck/modules/EditCheckDialog.js on lines 117..119
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 37..39
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 66..68
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 124..126
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 153..155
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 182..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.MWAdvancedPageSettingsDialogTool = function VeUiMWAdvancedPageSettingsDialogTool() {
    ve.ui.MWAdvancedPageSettingsDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 12 other locations - About 40 mins to fix
editcheck/modules/EditCheckDialog.js on lines 117..119
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 37..39
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 66..68
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 95..97
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 153..155
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 182..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.MWLanguagesDialogTool = function VeUiMWLanguagesDialogTool() {
    ve.ui.MWLanguagesDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 12 other locations - About 40 mins to fix
editcheck/modules/EditCheckDialog.js on lines 117..119
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 37..39
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 66..68
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 95..97
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 124..126
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 182..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.MWMetaDialogTool = function VeUiMWMetaDialogTool() {
    ve.ui.MWMetaDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 12 other locations - About 40 mins to fix
editcheck/modules/EditCheckDialog.js on lines 117..119
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 66..68
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 95..97
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 124..126
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 153..155
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 182..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

ve.ui.MWTemplatesUsedDialogTool = function VeUiMWTemplatesUsedDialogTool() {
    ve.ui.MWTemplatesUsedDialogTool.super.apply( this, arguments );
};
Severity: Major
Found in modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js and 12 other locations - About 40 mins to fix
editcheck/modules/EditCheckDialog.js on lines 117..119
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 35..37
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 53..55
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 71..73
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 89..91
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 107..109
modules/ve-mw/ui/tools/ve.ui.MWFormatTool.js on lines 136..138
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 37..39
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 66..68
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 95..97
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 124..126
modules/ve-mw/ui/tools/ve.ui.MWMetaDialogTool.js on lines 153..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status