Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function setupEditor has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.ui.MWAceEditorWidget.prototype.setupEditor = function () {
    let basePath = mw.config.get( 'wgExtensionAssetsPath', '' );

    if ( basePath.slice( 0, 2 ) === '//' ) {
        // ACE uses web workers, which have importScripts, which don't like relative links.
Severity: Minor
Found in modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js - About 1 hr to fix

    Function selectRange has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWAceEditorWidget.prototype.selectRange = function ( from, to ) {
    this.focus();
    this.loadingPromise.done( () => {
        const doc = this.editor.getSession().getDocument(),
            lines = doc.getAllLines();
    Severity: Minor
    Found in modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js - About 1 hr to fix

      Function getRange has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      ve.ui.MWAceEditorWidget.prototype.getRange = function () {
    let lines;
    function posToOffset( row, col ) {
        let offset = 0;
      Severity: Minor
      Found in modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status