Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js

Summary

Maintainability
C
1 day
Test Coverage

File ve.ui.MWCategoryWidget.js has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * VisualEditor UserInterface MWCategoryWidget class.
 *
 * @copyright See AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
Severity: Minor
Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js - About 2 hrs to fix

    Function queryCategoryStatus has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWCategoryWidget.prototype.queryCategoryStatus = function ( categoryNames ) {
    // Get rid of any we already know the hidden status of, or have an entry
    // if normalizedTitles (i.e. have been fetched before)
    const categoryNamesToQuery = categoryNames.filter( ( name ) => {
        if ( this.normalizedTitles[ name ] ) {
    Severity: Major
    Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js - About 2 hrs to fix

      Function addItems has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      ve.ui.MWCategoryWidget.prototype.addItems = function ( items, index ) {
    const categoryItems = [],
        // eslint-disable-next-line no-jquery/no-map-util
        categoryNames = $.map( items, ( item ) => item.name );
      Severity: Minor
      Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js - About 1 hr to fix

        Function VeUiMWCategoryWidget has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        ve.ui.MWCategoryWidget = function VeUiMWCategoryWidget( config ) {
    // Config initialization
    config = config || {};

    // Parent constructor
        Severity: Minor
        Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js - About 1 hr to fix

          Function queryCategoryStatus has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          ve.ui.MWCategoryWidget.prototype.queryCategoryStatus = function ( categoryNames ) {
    // Get rid of any we already know the hidden status of, or have an entry
    // if normalizedTitles (i.e. have been fetched before)
    const categoryNamesToQuery = categoryNames.filter( ( name ) => {
        if ( this.normalizedTitles[ name ] ) {
          Severity: Minor
          Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                              linkCacheUpdate[ pageInfo.title ] = {
                        missing: Object.prototype.hasOwnProperty.call( pageInfo, 'missing' ),
                        hidden: pageInfo.pageprops &&
                            Object.prototype.hasOwnProperty.call( pageInfo.pageprops, 'hiddencat' )
                    };
          Severity: Major
          Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js and 1 other location - About 1 hr to fix
          modules/ve-mw/ui/widgets/ve.ui.MWCategoryInputWidget.js on lines 92..98

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          ve.ui.MWCategoryWidget.prototype.onPopupOpened = function () {
    this.popup.removeButton.focus();
};
          Severity: Minor
          Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js and 1 other location - About 45 mins to fix
          modules/ve-mw/ui/tools/ve.ui.MWPopupTool.js on lines 44..46

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          ve.ui.MWCategoryWidget.prototype.getCategories = function () {
    return Object.keys( this.categories );
};
          Severity: Minor
          Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js and 1 other location - About 35 mins to fix
          modules/ve-mw/dm/models/ve.dm.MWTemplateSpecModel.js on lines 446..448

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          ve.ui.MWCategoryWidget.prototype.onPopupClosing = function () {
    this.expandedItem.focus();
};
          Severity: Major
          Found in modules/ve-mw/ui/widgets/ve.ui.MWCategoryWidget.js and 3 other locations - About 35 mins to fix
          modules/ve-mw/ui/inspectors/ve.ui.MWLiveExtensionInspector.js on lines 156..158
          modules/ve-mw/ui/pages/ve.ui.MWCategoriesPage.js on lines 262..264
          modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js on lines 317..319

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status