Sign upLogin

wikimedia/mediawiki-extensions-VisualEditor

View on GitHub
Star
modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js

Summary

Maintainability
C
1 day
Test Coverage

Function addExactMatch has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ve.ui.MWTemplateTitleInputWidget.prototype.addExactMatch = function ( response ) {
    const query = this.getQueryValue(),
        title = mw.Title.newFromText( query, this.namespace );
    // No point in trying anything when the title is invalid
    if ( !title ) {
Severity: Major
Found in modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js - About 2 hrs to fix

    Function getLookupRequest has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    ve.ui.MWTemplateTitleInputWidget.prototype.getLookupRequest = function () {
    let promise = ve.ui.MWTemplateTitleInputWidget.super.prototype.getLookupRequest.call( this );
    if ( mw.config.get( 'wgVisualEditorConfig' ).cirrusSearchLookup ) {
        promise = promise
            .then( this.addExactMatch.bind( this ) )
    Severity: Major
    Found in modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js - About 2 hrs to fix

      Function addExactMatch has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

      ve.ui.MWTemplateTitleInputWidget.prototype.addExactMatch = function ( response ) {
    const query = this.getQueryValue(),
        title = mw.Title.newFromText( query, this.namespace );
    // No point in trying anything when the title is invalid
    if ( !title ) {
      Severity: Minor
      Found in modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return this.getApi().get( {
        action: 'query',
        // Can't use a direct lookup by title because we need this to be case-insensitive
        generator: 'prefixsearch',
        gpssearch: query,
      Severity: Major
      Found in modules/ve-mw/ui/widgets/ve.ui.MWTemplateTitleInputWidget.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status