Sign upLogin

wikimedia/mediawiki-extensions-WikiLove

View on GitHub
Star
includes/ApiWikiLove.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method execute has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $params = $this->extractRequestParams();

        // In some cases we need the wiki mark-up stripped from the subject
        $strippedSubject = $this->parserFactory->getInstance()->stripSectionName( $params['subject'] );
Severity: Major
Found in includes/ApiWikiLove.php - About 2 hrs to fix

    Method getAllowedParams has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getAllowedParams() {
        return [
            'title' => [
                ParamValidator::PARAM_TYPE => 'string',
                ParamValidator::PARAM_REQUIRED => true,
    Severity: Minor
    Found in includes/ApiWikiLove.php - About 1 hr to fix

      Method saveInDb has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function saveInDb( $talk, $subject, $message, $type, $email ) {
        $dbw = $this->dbProvider->getPrimaryDatabase();
        $receiver = User::newFromName( $talk->getSubjectPage()->getBaseText() );
        if ( $receiver === false || $receiver->isAnon() || $receiver->isTemp() ) {
            $this->addWarning( 'apiwarn-wikilove-ignoringunregistered' );
      Severity: Minor
      Found in includes/ApiWikiLove.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute() {
        $params = $this->extractRequestParams();

        // In some cases we need the wiki mark-up stripped from the subject
        $strippedSubject = $this->parserFactory->getInstance()->stripSectionName( $params['subject'] );
        Severity: Minor
        Found in includes/ApiWikiLove.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method saveInDb has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function saveInDb( $talk, $subject, $message, $type, $email ) {
        Severity: Minor
        Found in includes/ApiWikiLove.php - About 35 mins to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  ApiMain $main,
        $action,
        IConnectionProvider $dbProvider,
        ParserFactory $parserFactory,
        PermissionManager $permissionManager
          Severity: Minor
          Found in includes/ApiWikiLove.php - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status