Sign upLogin

wikimedia/mediawiki-extensions-WikiLove

View on GitHub
Star

Showing 81 of 81 total issues

Function clickType has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    clickType: function ( e ) {
        let subtypeId, subtype;
        const newTypeId = $( this ).data( 'typeId' );

        e.preventDefault();
Severity: Minor
Found in resources/ext.wikiLove.startup/wikiLove.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getAllowedParams has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getAllowedParams() {
        return [
            'title' => [
                ParamValidator::PARAM_TYPE => 'string',
                ParamValidator::PARAM_REQUIRED => true,
Severity: Minor
Found in includes/ApiWikiLove.php - About 1 hr to fix

    Function rememberInputData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        rememberInputData: function () {
        if ( rememberData === null ) {
            rememberData = {
                header: '',
                title: '',
    Severity: Minor
    Found in resources/ext.wikiLove.startup/wikiLove.js - About 1 hr to fix

      Method onLoadExtensionSchemaUpdates has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function onLoadExtensionSchemaUpdates( $updater ) {
        $dbType = $updater->getDB()->getType();
        $path = dirname( __DIR__ ) . '/patches';
        if ( $dbType === 'mysql' ) {
            $updater->addExtensionTable( 'wikilove_log',
      Severity: Minor
      Found in includes/SchemaHooks.php - About 1 hr to fix

        Function submitSend has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            submitSend: function ( e ) {
        e.preventDefault();
        $( '#mw-wikilove-success' ).hide();
        $( '#mw-wikilove-dialog' ).find( '.mw-wikilove-error' ).remove();
        Severity: Minor
        Found in resources/ext.wikiLove.startup/wikiLove.js - About 1 hr to fix

          Method saveInDb has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function saveInDb( $talk, $subject, $message, $type, $email ) {
        $dbw = $this->dbProvider->getPrimaryDatabase();
        $receiver = User::newFromName( $talk->getSubjectPage()->getBaseText() );
        if ( $receiver === false || $receiver->isAnon() || $receiver->isTemp() ) {
            $this->addWarning( 'apiwarn-wikilove-ignoringunregistered' );
          Severity: Minor
          Found in includes/ApiWikiLove.php - About 1 hr to fix

            Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function execute() {
        $params = $this->extractRequestParams();

        // In some cases we need the wiki mark-up stripped from the subject
        $strippedSubject = $this->parserFactory->getInstance()->stripSectionName( $params['subject'] );
            Severity: Minor
            Found in includes/ApiWikiLove.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function submitSend has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                submitSend: function ( e ) {
        e.preventDefault();
        $( '#mw-wikilove-success' ).hide();
        $( '#mw-wikilove-dialog' ).find( '.mw-wikilove-error' ).remove();
            Severity: Minor
            Found in resources/ext.wikiLove.startup/wikiLove.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                showPreviewError: function ( errmsg ) {
        // eslint-disable-next-line mediawiki/msg-doc
        $( '#mw-wikilove-preview' ).append( $( '<div>' ).addClass( 'mw-wikilove-error' ).text( mw.msg( errmsg ) ) );
    },
            Severity: Major
            Found in resources/ext.wikiLove.startup/wikiLove.js and 1 other location - About 1 hr to fix
            resources/ext.wikiLove.startup/wikiLove.js on lines 460..463

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                showAddDetailsError: function ( errmsg ) {
        // eslint-disable-next-line mediawiki/msg-doc
        $( '#mw-wikilove-add-details' ).append( $( '<div>' ).addClass( 'mw-wikilove-error' ).text( mw.msg( errmsg ) ) );
    },
            Severity: Major
            Found in resources/ext.wikiLove.startup/wikiLove.js and 1 other location - About 1 hr to fix
            resources/ext.wikiLove.startup/wikiLove.js on lines 465..468

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function getUserTalkPage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function getUserTalkPage( PermissionManager $permissionManager, $title, $user ) {
        // Exit early if the sending user isn't logged in
        if ( !$user->isRegistered() || $user->isTemp() ) {
            return ApiMessage::create( 'wikilove-err-not-logged-in', 'notloggedin' );
        }
            Severity: Minor
            Found in includes/Hooks.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function doSend has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                doSend: function ( subject, wikitext, message, type, email, extraTags ) {
            Severity: Minor
            Found in resources/ext.wikiLove.startup/wikiLove.js - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          if ( $( '#mw-wikilove-message' ).val().indexOf( '~~~' ) >= 0 ) {
                $.wikiLove.showAddDetailsError( 'wikilove-err-sig' );
                return false;
            }
              Severity: Minor
              Found in resources/ext.wikiLove.startup/wikiLove.js and 1 other location - About 45 mins to fix
              resources/ext.wikiLove.startup/wikiLove.js on lines 390..393

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          if ( $( '#mw-wikilove-message' ).val().indexOf( '~~~' ) >= 0 ) {
                $.wikiLove.showAddDetailsError( 'wikilove-err-sig' );
                return false;
            }
              Severity: Minor
              Found in resources/ext.wikiLove.startup/wikiLove.js and 1 other location - About 45 mins to fix
              resources/ext.wikiLove.startup/wikiLove.js on lines 586..589

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      const termsLink = mw.html.element( 'a', {
            href: mw.msg( 'wikilove-terms-url' ),
            target: '_blank'
        }, mw.msg( 'wikilove-terms-link' ) );
              Severity: Minor
              Found in resources/ext.wikiLove.startup/wikiLove.js and 1 other location - About 40 mins to fix
              resources/ext.wikiLove.startup/wikiLove.js on lines 68..71

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      const commonsLink = mw.html.element( 'a', {
            href: mw.msg( 'wikilove-commons-url' ),
            target: '_blank'
        }, mw.msg( 'wikilove-commons-link' ) );
              Severity: Minor
              Found in resources/ext.wikiLove.startup/wikiLove.js and 1 other location - About 40 mins to fix
              resources/ext.wikiLove.startup/wikiLove.js on lines 72..75

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method saveInDb has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private function saveInDb( $talk, $subject, $message, $type, $email ) {
              Severity: Minor
              Found in includes/ApiWikiLove.php - About 35 mins to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        ApiMain $main,
        $action,
        IConnectionProvider $dbProvider,
        ParserFactory $parserFactory,
        PermissionManager $permissionManager
                Severity: Minor
                Found in includes/ApiWikiLove.php - About 35 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return $talkTitle;
                  Severity: Major
                  Found in includes/Hooks.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return ApiMessage::create( 'wikilove-err-cannot-edit', 'cannotedit' );
                    Severity: Major
                    Found in includes/Hooks.php - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language